Fix Wconversion warning in catch_reporter_helpers.cpp#3094
Open
PB-Ole wants to merge 1 commit intocatchorg:develfrom
Open
Fix Wconversion warning in catch_reporter_helpers.cpp#3094PB-Ole wants to merge 1 commit intocatchorg:develfrom
PB-Ole wants to merge 1 commit intocatchorg:develfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devel #3094 +/- ##
==========================================
- Coverage 91.36% 91.33% -0.03%
==========================================
Files 204 204
Lines 8903 8903
==========================================
- Hits 8134 8131 -3
- Misses 769 772 +3 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When compiling Catch2 with mingw and -Wconversion flag enabled the
catch_reporter_helpers.cppfile fails to build sincemaxTagCountLenis of typesize_tand used as input forstd::setwwhich expects anintas input.This simply fixes the type of
maxTagCountLenwhich is used nowhere else except for setting the stream width.GitHub Issues
I did not find an issue mentioning this. If needed, I can create one.