Skip to content

Conversation

@hanickadot
Copy link

@hanickadot hanickadot commented Jan 17, 2026

Description

This small PR add explicit cast from size_t to int when calling std::setw(...) to silence warning produced by GCC 15.2.

This also fixes conversions between sign types in Clang 21.1.8.

@hanickadot hanickadot changed the title Silence warning -Wconversion in GCC 15.2 Silence warning -Wconversion in GCC 15.2 and -Wsign-conversion in Clang 21.1.8 Jan 17, 2026
@codecov
Copy link

codecov bot commented Jan 17, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.15%. Comparing base (024aec9) to head (4f2d75d).

Additional details and impacted files
@@           Coverage Diff           @@
##            devel    #3061   +/-   ##
=======================================
  Coverage   91.14%   91.15%           
=======================================
  Files         202      202           
  Lines        8831     8832    +1     
=======================================
+ Hits         8049     8050    +1     
  Misses        782      782           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.


auto colInfo = tp.m_columnInfos[tp.m_currentColumn];
auto colInfo =
tp.m_columnInfos[static_cast<size_t>( tp.m_currentColumn )];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tp.m_currentColumn should be changed to be unsigned instead. The only place where it uses the fact that it is signed is using -1 as guard value after reset.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants