feat: support per-dimension link settings and sync collective dims#33
Open
horser1 wants to merge 1 commit into
Open
feat: support per-dimension link settings and sync collective dims#33horser1 wants to merge 1 commit into
horser1 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
related to #32
Summary
link_bwandlink_latencyto be specified as either scalars or per-dimension arraysnetwork.ymlandsystem.jsonringMotivation
ASTRA-Sim supports per-dimension bandwidth/latency when
npus_countis multi-dimensional, but LLMServingSim previously only exposed scalarlink_bw/link_latency.While adding array support, I also found that
network.ymlandsystem.jsonwere not using exactly the same topology-dimension inference path. In several multi-instance / PD / DP+EP configs,
network.ymlcould become 2D whilesystem.jsonstill emitted only one collective implementation entry per collective.This change centralizes topology-dimension inference so both files stay aligned.
Testing
Syntax / parsing