Draft
Conversation
Contributor
|
@CorentinDoue What about: interface EventStoreContext {
eventStoreId: string
}
interface SnapshotsQueryOptions {
aggregateId?: string
minVersion?: number
maxVersion? number
limit?: number
reverse?: boolean
reducerVersion?: string
pageToken?: string
}
interface SnapshotKey {
aggregateId: string
version: number
reducerVersion: string
}
interface SnapshotStorageAdapter {
listSnapshots( // <= Or maybe split between two methods: `listAllSnapshots` + `listAggregateSnapshots` ?
context: EventStoreContext,
options: SnapshotsQueryOptions = {}
) => Promise<{ snapshotsKeys: SnapshotKey[], nextPageToken?: string; }>
getSnapshot(snapshotKey: SnapshotKey, context: EventStoreContext) => Promise<{ snapshot: Aggregate }> // + possibly some useful metadata ?
putSnapshot(reducerVersion: string, snapshot: Aggregate, context: EventStoreContext) => Promise<void>
deleteSnapshot(snapshotKey: SnapshotKey, context: EventStoreContext) => Promise<void>
}And then for event stores: export const pokemonsEventStoreWithSnapshot = new EventStore({
...
reducerVersion: "v1.0.0", // <= I still think it's useful to version reducers outside of snapshots
snapshotStrategy: {
strategy: "PERIODIC", // or "NONE" or "CUSTOM"
periodInVersions: 100,
pruningStrategy: { // optional pruning strategy
strategy: "ON_NEW_SNAPSHOT", // or "NONE" or "TTL" for instance
keepLastVersions: 3
}
},
snapshotStorageAdapter,
}); |
|
Regarding getAggregate: I would hope that I could enable snapshots and benefit from them throughout my codebase without having to change all invocations. I personally would definitely prefer a breaking change that removes events from the return type, over having to add useSnapshot: true to all calls. |
Contributor
|
@oxc Yes the idea is that adding a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 🦫
Add snapshot capabilities :
consult
packages/core/src/eventStore/eventStore.unit.test.tsandpackages/core/src/eventStore/eventStore.fixtures.test.tsto know more.Fixes #181
Replaces #174
TODO 🚧
getAggregatesignature cf Question partConnectedEventStoreDynamoDbSnapshotStorageAdapterQuestions⁉️
I'm not sure about
getAggregatesignature with snapshot. CurrentlygetAggregatereturns{ aggregate, events, lastEvent };. But with snapshot returningeventsandlastEventis either cost expensive or misleading.Here are some propositions:
getAggregate, determine if snapshot must be use ifsnapshotConfigis defined. Return partialsevents(only those fetched) andlastEventonly if one event have been fetched additionally to a snapshotgetAggregate, add an explicituseSnapshotoption, determine if snapshot must be use ifuseSnapshotistrue. Return partialsevents(only those fetched) andlastEventonly if one event have been fetched additionally to a snapshotgetAggregatebut with signature BREAKING CHANGE. Determine if snapshot must be use ifsnapshotConfigis defined. Return onlyaggregate. Add a new explicitgetEventsAndAggregatecorresponding to currentgetAggregatewithout snapshot capabilitiesgetAggregateWithSnapshot. Determine if snapshot must be use ifsnapshotConfigis defined. Return onlyaggregate. LetgetAggregateas it is.Type of change 📝
Please delete options that are not relevant.
How Has This Been Tested? 🧑🔬
🚧
Test Configuration: 🔧
Checklist: ✅