Conversation
5049bb9 to
08e1d66
Compare
08e1d66 to
ba26eee
Compare
ba26eee to
d00313a
Compare
This was referenced Sep 13, 2025
Closed
|
If this is ever going to be picked up, please consider allowing the validate method to also return a Promise. At least for standard-schema support it would be extremely helpful if async results were supported out of the box, and would not have to be handled by throwing an exception. Given that validateEventDetail is called in pushEvent which is async anyway, this should hopefully not a major issue. (Not sure how well it would work with groupEvent, which does not yet seem to be considered in this draft... 😟) EDIT: In standard-schema, the validate method is defined like this: readonly validate: (
value: unknown
) => Result<Output> | Promise<Result<Output>>; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description 🦫
Add optional validation of an event input, and implement input validation for ZodEventTypes
Type of change 📝
Please delete options that are not relevant.
How Has This Been Tested? 🧑🔬
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration: 🔧
Checklist: ✅