Skip to content

Conversation

@Romfos
Copy link
Contributor

@Romfos Romfos commented Jan 5, 2026

Changes:

  • Add .NET 10 to test matrix

@Romfos Romfos mentioned this pull request Jan 5, 2026
10 tasks
@Romfos Romfos marked this pull request as ready for review January 5, 2026 14:10
@Romfos
Copy link
Contributor Author

Romfos commented Jan 5, 2026

looks like we have unstable tests

  Failed SimpleUsage [202 ms]
  Error Message:
   System.InvalidOperationException : Cannot open log for source 'test_source'. You may not have write access.
  ----> System.ComponentModel.Win32Exception : Access is denied.
  Stack Trace:
     at System.Diagnostics.EventLogInternal.OpenForWrite(String currentMachineName)
   at System.Diagnostics.EventLogInternal.InternalWriteEvent(UInt32 eventID, UInt16 category, EventLogEntryType type, String[] strings, Byte[] rawData, String currentMachineName)
   at System.Diagnostics.EventLogInternal.WriteEntry(String message, EventLogEntryType type, Int32 eventID, Int16 category, Byte[] rawData)
   at System.Diagnostics.EventLog.WriteEntry(String message, EventLogEntryType type, Int32 eventID, Int16 category, Byte[] rawData)
   at System.Diagnostics.EventLog.WriteEntry(String message, EventLogEntryType type)
   at Castle.Services.Logging.EventLogIntegration.DiagnosticsLogger.Log(LoggerLevel loggerLevel, String loggerName, String message, Exception exception) in /_/src/Castle.Services.Logging.EventLogIntegration/DiagnosticsLogger.cs:line 128
   at Castle.Core.Logging.LevelFilteredLogger.Log(LoggerLevel loggerLevel, String message, Exception exception) in /_/src/Castle.Core/Core/Logging/LevelFilteredLogger.cs:line 784
   at Castle.Core.Logging.LevelFilteredLogger.Warn(String message) in /_/src/Castle.Core/Core/Logging/LevelFilteredLogger.cs:line 402
   at Castle.Services.Logging.EventLogIntegration.Tests.DiagnosticsLoggerTestCase.SimpleUsage() in /_/src/Castle.Core.Tests/Services.Logging.Tests/DiagnosticLogger/DiagnosticsLoggerTestCase.cs:line 93
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodBaseInvoker.InvokeWithNoArgs(Object obj, BindingFlags invokeAttr)
--Win32Exception

@stakx
Copy link
Member

stakx commented Jan 5, 2026

looks like we have unstable tests

Yes we do (I'll gladly accept a PR that fixes it without just disabling the test). That's quite a frequent occurrence with this project, hence my reluctance to tinker with the CI build too often. 😉

@stakx stakx changed the title Added .NET 10 to test matrix Add .NET 10 to test matrix Jan 5, 2026
@stakx
Copy link
Member

stakx commented Jan 5, 2026

Btw. if we were doing this 100% correctly, we would be adding a .NET 10 test run to AppVeyor CI also (which at this time is the leading CI).

@Romfos
Copy link
Contributor Author

Romfos commented Jan 5, 2026

Btw. if we were doing this 100% correctly, we would be adding a .NET 10 test run to AppVeyor CI also (which at this time is the leading CI).

yes, or maybe better to drop tests from AppVeyor an use it only for release if you don't want to remove it now?
why do we need to run tests twice on 2 different ci systems...

@stakx
Copy link
Member

stakx commented Jan 5, 2026

maybe better to drop tests from AppVeyor

@Romfos, I've said it before but this is currently not an option. You may dislike it, but AppVeyor is currently the leading CI system for this project, and it is also the CI system responsible for publishing NuGet packages. Therefore it is imperative that we keep safeguards in place to avoid publishing faulty packages, and those safeguards are the AppVeyor test runs.

I would like to kindly ask you to stop repeatedly questioning the role of AppVeyor for this project, it's a waste of our time since for the moment we are still stuck with it, and I think we all agree that it's on its way out eventually. Until then, let's not make things worse by taking unnecessary shortcuts.

@stakx stakx merged commit cc3d3a8 into castleproject:master Jan 5, 2026
4 checks passed
@stakx
Copy link
Member

stakx commented Jan 5, 2026

Merged. Thank you, @Romfos!

@stakx stakx added this to the v6.0.0 milestone Jan 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants