fix(enforcer): add useAdapter param to avoid infinite loop in watchers by Huggin423 · Pull Request #536 · casbin/node-casbin

Huggin423 · 2026-01-06T05:29:56Z

CLAassistant · 2026-01-06T05:30:02Z

All committers have signed the CLA.

coveralls · 2026-01-06T05:44:01Z

Pull Request Test Coverage Report for Build 20748193976

Details

4 of 62 (6.45%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-2.7%) to 75.579%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
src/managementEnforcer.ts	0	7	0.0%
src/internalEnforcer.ts	4	55	7.27%

Totals
Change from base Build 20679550322:	-2.7%
Covered Lines:	1645
Relevant Lines:	2053

💛 - Coveralls

Copilot

Pull request overview

This PR fixes an infinite loop issue (#506) in watchers by adding a useAdapter parameter to internal policy management methods. When set to false, this parameter prevents adapter calls, which is crucial for the self* methods that are called from watchers to avoid triggering recursive adapter updates.

Key Changes

Added optional useAdapter parameter (defaults to true) to seven internal methods in InternalEnforcer
Updated all self* methods in ManagementEnforcer to pass false for both useWatcher and useAdapter parameters
Modified adapter conditional checks to include the new useAdapter flag

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 15 comments.

File	Description
src/internalEnforcer.ts	Added `useAdapter` parameter with default value `true` to seven internal methods and updated adapter conditional checks to respect this flag
src/managementEnforcer.ts	Updated six `self*` methods to pass `false` for the new `useAdapter` parameter

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-06T06:00:11Z

src/internalEnforcer.ts

    }

-    if (this.adapter && this.autoSave) {
+    // if (this.adapter && this.autoSave) {


Remove commented-out code. The old condition is no longer needed since the new condition with useAdapter is now in place.

Copilot · 2026-01-06T06:00:12Z

src/managementEnforcer.ts

    this.fm.addFunction(name, func);
  }
-
+  // add fifth argument


This comment is vague and unhelpful. Consider replacing it with a more descriptive comment explaining why the useAdapter parameter is needed, such as "Pass useAdapter=false to prevent infinite loops when called from watchers".

Suggested change

// add fifth argument

// Wrapper around addPolicyInternal that passes useAdapter=false (final argument)

// to prevent infinite update loops when invoked from watchers.

Copilot · 2026-01-06T06:00:12Z

src/internalEnforcer.ts

+  protected async addPoliciesInternal(
+    sec: string,
+    ptype: string,
+    rules: string[][],
+    useWatcher: boolean,
+    useAdapter = true
+  ): Promise<boolean> {


Add JSDoc parameter documentation for the new useAdapter parameter to explain its purpose. For example: "@param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)".

Copilot · 2026-01-06T06:00:12Z

src/internalEnforcer.ts

+  protected async addPoliciesInternalEx(
+    sec: string,
+    ptype: string,
+    rules: string[][],
+    useWatcher: boolean,
+    useAdapter = true
+  ): Promise<boolean> {


Add JSDoc parameter documentation for the new useAdapter parameter to explain its purpose. For example: "@param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)".

Copilot · 2026-01-06T06:00:12Z

src/internalEnforcer.ts

+  protected async removePoliciesInternal(
+    sec: string,
+    ptype: string,
+    rules: string[][],
+    useWatcher: boolean,
+    useAdapter = true
+  ): Promise<boolean> {


Add JSDoc parameter documentation for the new useAdapter parameter to explain its purpose. For example: "@param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)".

Copilot · 2026-01-06T06:00:13Z

src/internalEnforcer.ts

 */
 export class InternalEnforcer extends CoreEnforcer {
  /**
   * addPolicyInternal adds a rule to the current policy.


Add JSDoc parameter documentation for the new useAdapter parameter to explain its purpose. For example: "@param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)".

Suggested change

* addPolicyInternal adds a rule to the current policy.

* addPolicyInternal adds a rule to the current policy.

*

* @param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)

Copilot · 2026-01-06T06:00:14Z

src/internalEnforcer.ts

+  protected async removePolicyInternal(
+    sec: string,
+    ptype: string,
+    rule: string[],
+    useWatcher: boolean,
+    useAdapter = true
+  ): Promise<boolean> {


Add JSDoc parameter documentation for the new useAdapter parameter to explain its purpose. For example: "@param useAdapter whether to use the adapter for persistence (set to false to avoid infinite loops in watchers)".

Copilot · 2026-01-06T06:00:14Z

src/internalEnforcer.ts

    }

-    if (this.adapter && this.autoSave) {
+    // if (this.adapter && this.autoSave) {


Remove commented-out code. The old condition is no longer needed since the new condition with useAdapter is now in place.

Suggested change

// if (this.adapter && this.autoSave) {

Copilot · 2026-01-06T06:00:14Z

src/internalEnforcer.ts

    }

-    if (this.autoSave) {
+    // if (this.autoSave) {


Remove commented-out code. The old condition is no longer needed since the new condition with useAdapter is now in place.

Suggested change

// if (this.autoSave) {

Copilot · 2026-01-06T06:00:14Z

src/internalEnforcer.ts

+    useAdapter = true
  ): Promise<boolean> {
-    if (this.adapter && this.autoSave) {
+    // if (this.adapter && this.autoSave) {


Remove commented-out code. The old condition is no longer needed since the new condition with useAdapter is now in place.

hsluoyz · 2026-01-06T12:24:11Z

replaced by: #539

Huggin423 force-pushed the fix/506-bypass-adapter-loop branch 2 times, most recently from f08c0a4 to e68147f Compare January 6, 2026 05:52

hsluoyz requested a review from Copilot January 6, 2026 05:56

Copilot started reviewing on behalf of hsluoyz January 6, 2026 05:56 View session

Copilot AI reviewed Jan 6, 2026

View reviewed changes

Huggin423 force-pushed the fix/506-bypass-adapter-loop branch from e68147f to 75165bd Compare January 6, 2026 10:21

fix: fix yarn error

c64e7a6

Huggin423 force-pushed the fix/506-bypass-adapter-loop branch from 75165bd to c64e7a6 Compare January 6, 2026 10:41

Huggin423 closed this Jan 6, 2026

hsluoyz reopened this Jan 6, 2026

hsluoyz closed this Jan 6, 2026

	// add fifth argument
	// Wrapper around addPolicyInternal that passes useAdapter=false (final argument)
	// to prevent infinite update loops when invoked from watchers.

Uh oh!

Conversation

Huggin423 commented Jan 6, 2026

Uh oh!

CLAassistant commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coveralls commented Jan 6, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 20748193976

Details

💛 - Coveralls

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Key Changes

Reviewed changes

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Jan 6, 2026

Choose a reason for hiding this comment

Uh oh!

hsluoyz commented Jan 6, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

CLAassistant commented Jan 6, 2026 •

edited

Loading

coveralls commented Jan 6, 2026 •

edited

Loading