[Android] - Flag TotalCaloriesBurnedRecord permission as optional
#1280
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
In the current implementation of
HealthDataReader.handleWorkoutData()is forcing us to haveTotalCaloriesBurnedpermissions in ourAndroidManifest.xml:which can lead to Google review rejection if we don't actually has a feature to utilise TotalCaloriesBurned
(Excessive data access for declared feature). If we don't have those permissions added, we will get this error:Reason
Why is this necessary:
Because some apps out there might not require to utilise this data.
Solution
Some apps out there might not utilise this data. So in order to solve this issue, we would need to make
READ/WRITE_TOTAL_CALORIES_BURNEDas optional inAndroidManifest.xml. This PR adds a condition to check if the permission is present and granted, otherwise will skip to calculatetotalEnergyBurned.