-
Notifications
You must be signed in to change notification settings - Fork 12
Realm-index opt-in for prerendered isolated HTML #4769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
habdelra
wants to merge
6
commits into
main
Choose a base branch
from
indexer-perf/realm-index-opt-in
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
70d6160
Realm-index opt-in for prerendered isolated HTML
habdelra 0d4224c
Add integration tests for realm-index boilerplate substitution
habdelra 5a2fa61
Address PR review feedback: drop unreachable guard, tighten attribute…
habdelra 94d14ef
Include the new realm-info field in every realmInfo test fixture
habdelra 86eaecf
Correct realmInfo fixture default for unset opt-in field
habdelra fedf974
Revert realm-server testRealmInfo to false for indexed RealmConfig
habdelra File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,27 @@ | ||
| // Placeholder content the host returns as `isolatedHTML` when it | ||
| // decides to skip the full isolated render for the realm's default | ||
| // CardsGrid index card. The decision is made per-render in | ||
| // `card-prerender.gts` based on the card URL, its adoptsFrom chain, | ||
| // and the realm's `includePrerenderedDefaultRealmIndex` config field | ||
| // — see the realm-index opt-in PR for the surrounding rationale. | ||
| // | ||
| // The boilerplate is intentionally minimal. Anywhere the placeholder | ||
| // could be visible (the published-realm SSR injection slot, the | ||
| // error-page `lastKnownGoodHtml` fallback for an erroring realm | ||
| // index, or any future consumer reading `isolated_html` directly) is | ||
| // out of the search-result hot path; we just need valid HTML that | ||
| // the Ember runtime can replace cleanly on hydration. The wrapper | ||
| // shape matches what `withTimeout` in | ||
| // `packages/realm-server/prerender/utils.ts` captures from a real | ||
| // render so downstream consumers don't see a structurally different | ||
| // payload. | ||
| export const REALM_INDEX_BOILERPLATE_HTML = `<section data-prerender> | ||
| <div | ||
| class="boxel-cards-grid-shell" | ||
| data-boxel-cards-grid-index | ||
| aria-busy="true" | ||
| > | ||
| Prerendered HTML for default realm index is disabled (can be configured in realm.json) | ||
| </div> | ||
| </section> | ||
| `; |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.