Add issue-tracker demo cards#4674
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5f19a4c74d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let stored = this.args.model?.placements; | ||
| let cards = this.args.model?.cards ?? []; | ||
| if (stored?.length) { | ||
| let placedCardIds = new Set(stored.map((p) => p.itemId)); |
There was a problem hiding this comment.
Keep placed cards visible when a status option is removed
If a project status option is renamed or deleted while the board has stored placements, cards in that old status can disappear from the board: placedCardIds is populated before invalid placements are filtered out, so a placement whose effectiveKey and columnKey no longer match any current column returns null and then the card is excluded from the unplaced fallback. In that configuration change scenario, the issue is still in @model.cards but is no longer rendered; build the set from successfully resolved placements or fall back to column 0 for invalid stored columns.
Useful? React with 👍 / 👎.
Adding demo cards while #4650 is under review.