CS-10380: Fetch type picker options from _federated-types endpoint#4171
Draft
CS-10380: Fetch type picker options from _federated-types endpoint#4171
Conversation
Instead of deriving type picker options from search results and recent cards, fetch all available types from the _federated-types endpoint so the picker is populated with all types across selected realms regardless of search state. Types with the same display_name but different code_refs appear as one picker option, but all associated code_refs are used when filtering search results. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Preview deployments |
Host Test Results 1 files ±0 1 suites ±0 2h 30m 4s ⏱️ -40s For more details on these errors, see this check. Results for commit 1aeeebf. ± Comparison against base commit 0da90e3. This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.♻️ This comment has been updated with latest results. |
- Add built-in infinite scroll and loading indicators to the boxel-ui Picker component (isLoading, isLoadingMore, hasMore, onLoadMore args) - Full overlay loading covers options area during initial/search fetch, bottom spinner shows during load-more pagination - Simplify TypePicker by removing custom afterOptionsComponent, infiniteScroll modifier, and pickerExtra - now passes args directly - Split _typeSummariesLoading into _isLoadingTypes and _isLoadingMoreTypes for distinct loading states - Update tests for pagination (waitFor specific types) and type count Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2026-03-13.at.16.03.28.mov
Summary
_federated-typesendpoint instead of deriving them from search resultsTypePickerinto the boxel-uiPickercomponentChanges
packages/boxel-ui/addon/src/components/picker/index.gtsisLoading,isLoadingMore,hasMore,onLoadMoreargs to PickerPickerAfterOptionscomponent with full overlay loading for initial/search and bottom spinner for load-morerequestAnimationFramedropdownClassadds--loadingmodifier for z-index layering (search input stays above overlay)packages/host/app/components/type-picker/index.gts@isLoading,@isLoadingMore,@hasMore,@onLoadMoredirectly to Pickerpackages/host/app/components/card-search/panel.gtsfetchTypeSummariesrestartable task callingrealmServer.fetchCardTypeSummaries()_isLoadingTypes(initial/search) and_isLoadingMoreTypes(pagination)_typeCodeRefsmap tracks multiple code refs per display name for accurate search filteringpackages/host/app/components/card-search/search-bar.gtsisLoadingTypesarg, passed through to TypePickerTests
waitForfor paginated type options in operator-mode UI testsTest plan
packages/hostintegration tests for operator-mode UI🤖 Generated with Claude Code