Conversation
Preview deployments |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 714a487104
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for (let result of results.tests) { | ||
| let entry = this.tests.find((t) => t.name === result.name); | ||
| if (!entry) continue; | ||
| entry.status = result.status === 'pass' ? 'pass' : 'fail'; | ||
| entry.errorMessage = result.error?.message; |
There was a problem hiding this comment.
When / _run-tests returns an error payload with an empty tests array (for example, module import failure or prerender timeout), this loop never updates any of the entries that were set to running, so the UI stays in a perpetual running state with no actionable failure shown. Because the backend already returns status: "error" in these cases, the panel should explicitly transition any still-running toRun entries to fail (with a generic message) after processing results.tests.
Useful? React with 👍 / 👎.
| (globalThis as any).QUnit = { | ||
| test(name: string) { | ||
| names.push(name); | ||
| }, | ||
| module(_name: string, optionsOrFn?: any, maybeFn?: any) { |
There was a problem hiding this comment.
This stub only defines test and module, but the qunit shim falls back to the real module for any missing key, so files that use import QUnit from 'qunit' (default export) will execute QUnit.test on the real runner instead of this collector and their tests will not be discovered in the panel. Include a default property that points at the stubbed API (or preserve/patch the previous global) so both named and default import styles are captured.
Useful? React with 👍 / 👎.
1 participant
No description provided.