Conversation
|
To use Codex here, create a Codex account and connect to github. |
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 779a18d413
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
packages/catalog-realm/submission-card/submission-card-portal.gts
Outdated
Show resolved
Hide resolved
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4e9ba01196
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| get prCardInstance() { | ||
| return this.prCardData?.instances?.[0] ?? null; |
There was a problem hiding this comment.
prCardInstance always selects instances[0], but the query only filters by branchName and does not define a sort order. The index query engine defaults unsorted searches to ORDER BY url (packages/runtime-common/index-query-engine.ts:583-586), so if multiple PR cards exist for the same branch (for example after closing and reopening a PR), this can resolve to an older card instead of the current one; please add an explicit descending sort (e.g., by lastModified or submittedAt) before reading the first instance.
Useful? React with 👍 / 👎.
lucaslyl
force-pushed
the
CS-10291-create-submission-card-portal
branch
from
607ff12 to
afa3185
Compare
1 participant
linear: https://linear.app/cardstack/issue/CS-10291/create-submission-card-portal
Screen.Recording.2026-03-12.at.8.19.29.PM.mov