Skip to content

Python MANIFEST: add missing xprint.py in tests/#2871

Closed
Jvlegod wants to merge 1 commit intocapstone-engine:nextfrom
Jvlegod:fix-xprint
Closed

Python MANIFEST: add missing xprint.py in tests/#2871
Jvlegod wants to merge 1 commit intocapstone-engine:nextfrom
Jvlegod:fix-xprint

Conversation

@Jvlegod
Copy link
Copy Markdown

@Jvlegod Jvlegod commented Feb 24, 2026

When setup.py is executed, the packaged tests directory will be missing the xprint.py file, which will cause test cases to fail.

Closing issues

closes #2870

When setup.py is executed, the packaged tests directory will
be missing the xprint.py file, which will cause test cases
to fail.

Signed-off-by: Jvle <keke.oerv@isrc.iscas.ac.cn>
@github-actions github-actions bot added the Python Bindings label Feb 24, 2026
@Rot127
Copy link
Copy Markdown
Collaborator

Rot127 commented Feb 25, 2026

@Antelox I can't find the PR or issue. But did we maybe do this on purpose to have the release packages smaller? If so the solution would be to not include the test_all.py

Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment needs to be clarified first: #2870 (comment)

Also. the error shows you run v5.0.3, but the PR goes to next branch. They are widely different.

@Jvlegod
Copy link
Copy Markdown
Author

Jvlegod commented Feb 25, 2026

This comment needs to be clarified first: #2870 (comment)

Also. the error shows you run v5.0.3, but the PR goes to next branch. They are widely different.

I left my explanation in the issue. :>

@Rot127 Rot127 changed the title bindings/python: fix missing xprint.py in tests Python MANIFEST: add missing xprint.py in tests/ Feb 25, 2026
Copy link
Copy Markdown
Collaborator

@Rot127 Rot127 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's wait for @Antelox review though.

@Antelox
Copy link
Copy Markdown
Contributor

Antelox commented Feb 27, 2026

I have explained actual issue in the related ticket. I'm gonna create PR to remove xprint dependency. Issue is not with the sdist size since tests are already included and the only missing file is the xprint.py as already reported.

@Rot127 Between v5 and v6, some tests got removed so should I open 2 PRs, one targeting next branch and one targeting v5 branch?

@Rot127
Copy link
Copy Markdown
Collaborator

Rot127 commented Feb 28, 2026

Between v5 and v6, some tests got removed so should I open 2 PRs, one targeting next branch and one targeting v5 branch?

@Antelox Yes, this is a good idea.

@Antelox
Copy link
Copy Markdown
Contributor

Antelox commented Feb 28, 2026

FYI I have created the 2 PRs:

#2873
#2874

If all good I suppose we can close this PR.

@Rot127
Copy link
Copy Markdown
Collaborator

Rot127 commented Mar 2, 2026

Thanks a lot for making the PR here though! @Jvlegod

Fixed with:
#2873
#2874

@Rot127 Rot127 closed this Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Python Bindings

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bindings/python: xprint.py missing from PyPI distribution

3 participants