Python MANIFEST: add missing xprint.py in tests/#2871
Python MANIFEST: add missing xprint.py in tests/#2871Jvlegod wants to merge 1 commit intocapstone-engine:nextfrom
Conversation
When setup.py is executed, the packaged tests directory will be missing the xprint.py file, which will cause test cases to fail. Signed-off-by: Jvle <keke.oerv@isrc.iscas.ac.cn>
|
@Antelox I can't find the PR or issue. But did we maybe do this on purpose to have the release packages smaller? If so the solution would be to not include the |
There was a problem hiding this comment.
This comment needs to be clarified first: #2870 (comment)
Also. the error shows you run v5.0.3, but the PR goes to
nextbranch. They are widely different.
I left my explanation in the issue. :> |
|
I have explained actual issue in the related ticket. I'm gonna create PR to remove xprint dependency. Issue is not with the sdist size since tests are already included and the only missing file is the xprint.py as already reported. @Rot127 Between v5 and v6, some tests got removed so should I open 2 PRs, one targeting |
@Antelox Yes, this is a good idea. |
When setup.py is executed, the packaged tests directory will be missing the xprint.py file, which will cause test cases to fail.
Closing issues
closes #2870