🐛 Fix: Approve CAP error shows before wallet confirmation#187
Open
chinaxiao123 wants to merge 1 commit into
Open
🐛 Fix: Approve CAP error shows before wallet confirmation#187chinaxiao123 wants to merge 1 commit into
chinaxiao123 wants to merge 1 commit into
Conversation
Fix for issue capofficial#32: - Add loading state (isSubmitting) to Approve CAP button - Handle MetaMask rejection silently (no error popup) - Refresh allowance check after successful approval - Prevent error display while waiting for wallet confirmation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Problem
When clicking "Approve CAP" on the Stake modal, an error was displayed before the wallet (MetaMask) confirmation. This was caused by:
isSubmittingstate, so users saw no feedback during wallet interactionChanges
src/api/assets.js—approveAsset()user denied/user rejected/user cancellederrors (no error popup when user cancels in MetaMask)src/components/modals/StakeCAP.svelte—_approveAsset()isSubmitting = truebefore calling approveAssetisSubmitting = falseafter completioncheckAllowance()) after successful approvalisLoading={isSubmitting})Testing