Conversation
.github/workflows/cf.yaml
Outdated
| push: | ||
| branches: | ||
| - main | ||
| pull_request: |
There was a problem hiding this comment.
Will remove this before merging so deployments are only done for pushes on main.
| config.activate.on-profile: cloud | ||
| cds: | ||
| security.mock.users: {} | ||
| --- |
There was a problem hiding this comment.
AMS requires us to disable mock users in the cloud… otherwise you get cryptic errors on Java server startup:
https://github.com/capire/xtravels-java/actions/runs/21216937849/job/61040618351#step:9:969
There was a problem hiding this comment.
Thanks for finding that. AFAIK that's actually a known issue. @BraunMatthias Isn't this fixed yet?
.github/workflows/test.yaml
Outdated
| name: Tests | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| merge_group: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: read | ||
|
|
||
| jobs: | ||
| tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 22 | ||
| - uses: actions/checkout@v6 | ||
| - run: npm install | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: sapmachine | ||
| java-version: 21 | ||
| cache: maven | ||
| - run: mvn test -B |
There was a problem hiding this comment.
This workflow and https://github.com/capire/xtravels-java/blob/main/.github/workflows/maven.yml seem quite redundant now. Imo we should keep this one, as it also runs tests and doesn't just build the project.
There was a problem hiding this comment.
The other workflow also runs the tests, as test execution is included in mvn package :)
Also we shouldn't need to do an explicit npm install in a Java-based project.
There was a problem hiding this comment.
Right, missed that in the other workflow's output. Still quite redundant, so should we just keep the maven.yaml one?
Revert security.mock.users configuration to include admin roles and change profile activation condition.
.github/workflows/test.yaml
Outdated
| name: Tests | ||
|
|
||
| on: | ||
| workflow_call: | ||
| workflow_dispatch: | ||
| pull_request: | ||
| merge_group: | ||
| push: | ||
| branches: | ||
| - main | ||
|
|
||
| permissions: | ||
| contents: read | ||
| packages: read | ||
|
|
||
| jobs: | ||
| tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/setup-node@v6 | ||
| with: | ||
| node-version: 22 | ||
| - uses: actions/checkout@v6 | ||
| - run: npm install | ||
| env: | ||
| NODE_AUTH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| - uses: actions/setup-java@v5 | ||
| with: | ||
| distribution: sapmachine | ||
| java-version: 21 | ||
| cache: maven | ||
| - run: mvn test -B |
There was a problem hiding this comment.
The other workflow also runs the tests, as test execution is included in mvn package :)
Also we shouldn't need to do an explicit npm install in a Java-based project.
| config.activate.on-profile: cloud | ||
| cds: | ||
| security.mock.users: {} | ||
| --- |
There was a problem hiding this comment.
Thanks for finding that. AFAIK that's actually a known issue. @BraunMatthias Isn't this fixed yet?
|
Deployed app looks good on first sight: 
|
|
@beckermarc just sent the BTP links where the app is hosted to you via mail. |
|
Thanks a lot, very nice! Bonus would now be: Add the same to XFlights and connect them to each other in Production deployments. For Staging we could use the mocked mode, as done right now. |
Removed pull_request trigger from workflow.
2 participants
No description provided.