WIP: [CFM-861-tests] Add Behat tests for permissions. by anvmn · Pull Request #1494 · capacity4dev/capacity4more

anvmn · 2016-11-09T12:03:56Z

Derives from #1445

Coder

Update selector - remove condition that never occurs

ordavidil · 2016-11-09T16:22:00Z

      $target_access = og_user_access($group_type, $group['gid'], "create $node_type content");
      // Any member can edit a wiki page unless a power user has changed it
      // specifically for a specific node.
-      if (!empty($this->entity->nid) && $node_type == 'wiki_page') {


Not sure about this one ....

As I see it at code, selector is activated at og.module hook_node_access(), line 523.
This activation is inside following if (line 501):
if ($op == 'create' && og_is_group_content_type('node', $type))

This means that selector is activated only when creating group content. Right?

It fixed the bug we had, see travis for 84154e0

This commit doesn't have the !empty($this->entity->nid) condition.
empty($this->entity->nid) will return TRUE when creating node, so
!empty($this->entity->nid) will always return FALSE, if we create a node.

The condition was added at 56db585.

but here you've removed part of it ...

Restored the condition

…ess can not be altered if it's missing.

ordavidil · 2016-11-10T16:37:46Z

+      | mariecurie  | /node/add/event |
+      | mariecurie  | /node/add/document |
+      | mariecurie  | /node/add/discussion |
+      | mariecurie  | /node/add/wiki-page |


@anvmn
please add /node/add/news as well

looshkin · 2016-11-10T17:30:46Z

+    Examples:
+      | user        | path                 |
+      | isaacnewton | /draft/node/add/photoalbum |
+      | isaacnewton | /published/node/add/photo |


this should be /draft/... instead of /published/... for lines 251-272

looshkin · 2016-11-10T17:41:12Z

+      | mariecurie  | /published/node/add/document |
+      | mariecurie  | /published/node/add/discussion |
+      | mariecurie  | /published/node/add/wiki-page |
+


we also need to update the path to /draft/ instead of /pending/ for all lines from 251 to 272

Fixed. Also, lines 194-216.

looshkin · 2016-11-10T17:44:38Z

+      | mariecurie  | /published/node/add/document |
+      | mariecurie  | /published/node/add/discussion |
+      | mariecurie  | /published/node/add/wiki-page |
+


we also need to update the path to /draft/ instead of /pending/ for all lines from 307 to 328

looshkin · 2016-11-10T17:47:44Z

+    When   I change access of group "Published group" to "Public"
+    Then   I am an anonymous user
+    And    I go to "published"
+    And    I should see "Please log in"


wrong - a visitor can access and view all contents in a published public group - he does not need to login
to create content though, he needs to become a member via combined workflow

looshkin · 2016-11-10T17:54:23Z

+    When  I change access of group "Archived group" to "Public"
+    Then  I am an anonymous user
+    And   I go to "archived"
+    And   I should see "Please log in"


wrong - a visitor can access and view all contents in a published archived group - he does not need to login
Archived groups are read only so visitors cannot request membership

looshkin · 2016-11-10T17:59:20Z

+      | mariecurie  |  /deleted/node/add/document |
+      | mariecurie  |  /deleted/node/add/discussion |
+      | mariecurie  |  /deleted/node/add/wiki-page |
+


no we agreed with Aki this AM that both pending and deleted groups would prevent any user from creating content - so please add lines 716 to 721 in the scenario below, described under line 724

looshkin · 2016-11-10T18:00:38Z

+      | mariecurie  | /deleted/node/add/document |
+      | mariecurie  | /deleted/node/add/discussion |
+      | mariecurie  | /deleted/node/add/wiki-page |
+


no we agreed with Aki this AM that deleted groups would prevent any user from creating content - so please delete scenario described under 765 and add lines 772 to 777 in the scenario described under line 780

looshkin · 2016-11-10T18:01:26Z

+      | mariecurie  | /deleted/node/add/document |
+      | mariecurie  | /deleted/node/add/discussion |
+      | mariecurie  | /deleted/node/add/wiki-page |
+


no we agreed with Aki this AM that deleted groups would prevent any user from creating content - so please delete scenario described under 821 and add lines 828 to 833 in the scenario described under line 836

looshkin · 2016-11-10T18:16:02Z

As a general comment for the create content permissions...
Even if news is not meant to be a Group Content Type, today a GM/GA/GO/SA is able to create news inside a group - this generates all the expected behaviour except the display of an item in the discussions overview. So to prevent this behaviour, I would add /node/add/news to the scenarios for all users

ordavidil · 2016-11-10T18:17:20Z

@anvmn ^^

ordavidil · 2016-11-13T10:32:52Z

@anvmn
all permission tests should moved to a new build on travis.

change all tags to @permission
add another env on .travis.yml

  - INSTALL_PROFILE=1
    BEHAT_TAG="permission"
    CODE_REVIEW=0
    SIMPLETEST=0

modify run_behat.sh like:

# Run tests for the permission tag.
if [ "$BEHAT_TAG" = "permission" ]; then
  ./bin/behat --tags='@permission&&~@wip'
fi

…oup' requirement

…ublic group

anvmn · 2016-11-13T19:43:51Z

Closing in favor of #1523

Code from #1491

b83aadd

This was referenced Nov 9, 2016

[CFM-861] Adjust permissions and align groups presentation. #1445

Closed

WIP: [CFM-861-tests] Add Behat tests for permissions. #1491

Closed

anvmn added 4 commits November 9, 2016 15:37

Fix regex

8641852

Coder

Add wiki-page tests

8926b6c

Handle wiki page creation at for access

9cf56ea

Update selector - remove condition that never occurs

Site admin may not create content at pending group

fe69185

ordavidil reviewed Nov 9, 2016

View reviewed changes

anvmn added 3 commits November 9, 2016 19:06

Restore condition at selector

add18f7

Reformat form access function

2a2e818

Adding banner to groups info, as it's a required field, and group acc…

640f358

…ess can not be altered if it's missing.

ordavidil reviewed Nov 10, 2016

View reviewed changes

looshkin reviewed Nov 10, 2016

View reviewed changes

Code review by Diane [ci skip]

d27773c

looshkin reviewed Nov 10, 2016

View reviewed changes

anvmn added 2 commits November 10, 2016 20:06

Prevent site admin from adding content to deleted group [ci skip]

c8a8075

Docs [ci skip]

994763d

anvmn added 4 commits November 13, 2016 13:17

Rename constants

627475e

Adding 'permision' build environment on Travis

93c8273

Adjusts tests for 'SA should not be able to add content to deleted gr…

33ab8ad

…oup' requirement

Fix tests - anonymous user should have access to published/archived p…

92abc6e

…ublic group

anvmn mentioned this pull request Nov 13, 2016

[CFM-861] Adjust group permissions and align groups presentation. #1520

Merged

anvmn added a commit that referenced this pull request Nov 13, 2016

From #1494

5791499

anvmn closed this Nov 13, 2016

anvmn deleted the feature/CFM-861-permission-behat-tests branch November 13, 2016 19:43

anvmn mentioned this pull request Nov 13, 2016

[CFM-861-tests] Behat tests for permissions. #1523

Open

Conversation

anvmn commented Nov 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Derives from #1445

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anvmn Nov 9, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anvmn Nov 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anvmn Nov 13, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin Nov 10, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

looshkin commented Nov 10, 2016

Uh oh!

ordavidil commented Nov 10, 2016

Uh oh!

ordavidil commented Nov 13, 2016

Uh oh!

anvmn commented Nov 13, 2016

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

anvmn commented Nov 9, 2016 •

edited

Loading

anvmn Nov 9, 2016 •

edited

Loading

looshkin Nov 10, 2016 •

edited

Loading

looshkin Nov 10, 2016 •

edited

Loading

anvmn Nov 13, 2016 •

edited

Loading

looshkin Nov 10, 2016 •

edited

Loading

anvmn Nov 13, 2016 •

edited

Loading

looshkin Nov 10, 2016 •

edited

Loading

looshkin Nov 10, 2016 •

edited

Loading