Skip to content

chore: CI runs with node 22 and 24#421

Open
sjvans wants to merge 1 commit into
mainfrom
node-24
Open

chore: CI runs with node 22 and 24#421
sjvans wants to merge 1 commit into
mainfrom
node-24

Conversation

@sjvans
Copy link
Copy Markdown
Contributor

@sjvans sjvans commented May 13, 2026

Update CI Node.js Versions to 22 and 24

Chore

🔧 Updated the CI pipeline to test against Node.js versions 22 and 24, replacing the previously used versions 20 and 22.

Changes

  • .github/workflows/ci.yml: Updated the node-version matrix from [22.x, 20.x] to [24.x, 22.x], dropping Node.js 20 support and adding Node.js 24 to the test matrix.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.20.47

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • Summary Prompt: Default Prompt
  • Output Template: Default Template
  • Correlation ID: 1be99873-b0ad-46ce-9776-4eb083e7397b

@sjvans sjvans requested a review from johannes-vogel May 13, 2026 13:46
Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Node.js matrix update looks straightforward. The only actionable issue found — beyond the diff itself — is that both actions/checkout and actions/setup-node remain on the outdated v2 tag throughout the file. This is worth fixing alongside the Node.js version bump, especially since Node.js 24 is being added and newer action versions have better compatibility guarantees with modern runtimes.

PR Bot Information

Version: 1.20.47

  • File Content Strategy: Full file content
  • LLM: anthropic--claude-4.6-sonnet
  • Event Trigger: pull_request.opened
  • Correlation ID: 1be99873-b0ad-46ce-9776-4eb083e7397b

Comment thread .github/workflows/ci.yml
node-version: [24.x, 22.x]
cds-version: [9, 8]
steps:
- uses: actions/checkout@v2
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Best Practices: actions/checkout and actions/setup-node are pinned to outdated v2 tags

Both actions/checkout@v2 and actions/setup-node@v2 are significantly outdated. The current major versions are v4 for both actions. Using stale action versions can expose the workflow to known bugs and missing security fixes, and v2 of these actions predates Node.js 20+ compatibility improvements.

Consider upgrading to the latest major versions:

Suggested change
- uses: actions/checkout@v2
- uses: actions/checkout@v4

Double-check suggestion before committing. Edit this comment for amendments.


Please provide feedback on the review comment by checking the appropriate box:

  • 🌟 Awesome comment, a human might have missed that.
  • ✅ Helpful comment
  • 🤷 Neutral
  • ❌ This comment is not helpful

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant