Skip to content

chore: reduce wait times#419

Open
sjvans wants to merge 2 commits into
mainfrom
reduce-wait-times
Open

chore: reduce wait times#419
sjvans wants to merge 2 commits into
mainfrom
reduce-wait-times

Conversation

@sjvans
Copy link
Copy Markdown
Contributor

@sjvans sjvans commented Apr 28, 2026

Reduce Test Wait Times for Metrics Collection

Chore

⚡ Reduced hardcoded wait times in metrics-related tests from 300ms to 150ms, cutting unnecessary delays in the test suite.

Changes

  • test/metrics-outbox-multitenant.test.js: Reduced all wait(300) calls used for metrics collection to wait(150).
  • test/metrics-outbox.test.js: Reduced all wait(300) calls used for metrics collection to wait(150), across multiple test cases covering immediate success, retry scenarios, and cold entry observation.
  • 🔄 Regenerate and Update Summary
PR Bot Information

Version: 1.20.33

  • Correlation ID: f28eb04d-3218-4c2b-a550-fd6dd09fc04b
  • Output Template: Default Template
  • File Content Strategy: Full file content
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet
  • Summary Prompt: Default Prompt

Copy link
Copy Markdown
Contributor

@hyperspace-insights hyperspace-insights Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The duplicate while loop (line 175 in the full file) is a pre-existing issue not introduced by this PR, so it's outside the scope of this review. The only changes in the diff are the wait(300)wait(150) reductions.

With exportIntervalMillis = 100ms, a wait(150) provides a 1.5× safety margin over the export interval, which is reasonable. The changes are consistent across both test files and reduce total test execution time without introducing any logic errors.

The PR is a straightforward, low-risk change that halves wait times across all metric collection delays. No issues were found in the diffed lines.

PR Bot Information

Version: 1.20.33

  • Correlation ID: f28eb04d-3218-4c2b-a550-fd6dd09fc04b
  • File Content Strategy: Full file content
  • Event Trigger: pull_request.opened
  • LLM: anthropic--claude-4.6-sonnet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant