chore: reduce wait times#419
Open
sjvans wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
The duplicate while loop (line 175 in the full file) is a pre-existing issue not introduced by this PR, so it's outside the scope of this review. The only changes in the diff are the wait(300) → wait(150) reductions.
With exportIntervalMillis = 100ms, a wait(150) provides a 1.5× safety margin over the export interval, which is reasonable. The changes are consistent across both test files and reduce total test execution time without introducing any logic errors.
The PR is a straightforward, low-risk change that halves wait times across all metric collection delays. No issues were found in the diffed lines.
PR Bot Information
Version: 1.20.33
- Correlation ID:
f28eb04d-3218-4c2b-a550-fd6dd09fc04b - File Content Strategy: Full file content
- Event Trigger:
pull_request.opened - LLM:
anthropic--claude-4.6-sonnet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reduce Test Wait Times for Metrics Collection
Chore
⚡ Reduced hardcoded wait times in metrics-related tests from
300msto150ms, cutting unnecessary delays in the test suite.Changes
test/metrics-outbox-multitenant.test.js: Reduced allwait(300)calls used for metrics collection towait(150).test/metrics-outbox.test.js: Reduced allwait(300)calls used for metrics collection towait(150), across multiple test cases covering immediate success, retry scenarios, and cold entry observation.PR Bot Information
Version:
1.20.33f28eb04d-3218-4c2b-a550-fd6dd09fc04bpull_request.openedanthropic--claude-4.6-sonnet