Bug compostion not found wrong namespace (Issue #243)#249
Open
Andreas-Meindl-msggroup wants to merge 834 commits into
Open
Bug compostion not found wrong namespace (Issue #243)#249Andreas-Meindl-msggroup wants to merge 834 commits into
Andreas-Meindl-msggroup wants to merge 834 commits into
Conversation
…into containment-error-cds8
…d of .docx as .docx file is restricted in test repo
[Hyperspace] 🤖 Add PR Bot Configuration
Fix [NodeJs] Incorrect Warning message if a user without SDM Roles updates custom properties or renames attachments
FIX Setting the custom properties value to null doesn't revert the value in SDM
fix for draft edit link
Edit link automation
Change Log for Release 1.9.0 & an error message fix in Integration test
rashmiangadi05
approved these changes
Apr 15, 2026
Collaborator
rashmiangadi05
left a comment
rashmiangadi05
left a comment
There was a problem hiding this comment.
Looks good. We ll run integration testa nd then merge it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
Deleting files is not possible as in sdm.js file in method getAttachmentCompositions there is if statement "if (targetDef && targetDef.includes && targetDef.includes.includes('sap.attachments.Attachments'))".
In our case targetDef is not "sap.attachments.Attachments" but only "Attachments".
Deleting a file on UI results in a deleted file on UI attachment table but not in the DMS.
Type of change
Checklist before requesting a review
Upload Screenshots/lists of the scenarios tested