Using environment secrets for maven and pgp#196
Open
BraunMatthias wants to merge 6 commits into
Open
Conversation
Schmarvinius
requested changes
May 21, 2026
Schmarvinius
left a comment
Schmarvinius
left a comment
There was a problem hiding this comment.
In Attachments, we have an approval gate for release. I created a 2nd environment for this. Now we have one for release where the secrets are in and one for release-approval. Sadly if you combine them you need to approve every step, that's why I separated them.
Not mandatory but nice to have. You can decide yourself if you want to keep that too
Comment on lines
71
to
77
| - name: Upload Changed Artifacts | ||
| uses: actions/upload-artifact@v6 | ||
| with: | ||
| name: root-build | ||
| include-hidden-files: true | ||
| path: . | ||
| retention-days: 1 |
There was a problem hiding this comment.
I think keeping that doesn't make any sense and only complicates. Can you remove the upload here and the download in deploy (switch to checkout instead)
Author
There was a problem hiding this comment.
afaik the upload of the built artifacts is required as prerequisite for the deploy
Schmarvinius
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.