Remove flags field from NewAtomicFile calls#548
Open
olivercalder wants to merge 1 commit into
Open
Conversation
The `osutil.AtomicWriteFlags` has had its only flag value removed from snapd, as that flag had been unused since 2016. Now, since all the `flags osutil.AtomicWriteFlags` fields were ignored, we want to remove those fields from snapd as well. However, snapd vendors secboot, and secboot uses `osutil.NewAtomicFile` from snapd, so we can't make the change in snapd without first making the change in secboot. Once this secboot change lands and a new secboot build is available, then we can bump the secboot version used by snapd within the PR which changes the `osutil` function signatures. Then, after that PR within snapd lands, we can bump the snapd version which secboot builds against. That PR within snapd is canonical/snapd#17129 Signed-off-by: Oliver Calder <oliver.calder@canonical.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
osutil.AtomicWriteFlagshas had its only flag value removed from snapd, as that flag had been unused since 2016. Now, since all theflags osutil.AtomicWriteFlagsfields were ignored, we want to remove those fields from snapd as well. However, snapd vendors secboot, and secboot usesosutil.NewAtomicFilefrom snapd, so we can't make the change in snapd without first making the change in secboot.Once this secboot change lands and a new secboot build is available, then we can bump the secboot version used by snapd within the PR which changes the
osutilfunction signatures. Then, after that PR within snapd lands, we can bump the snapd version which secboot builds against.That PR within snapd is canonical/snapd#17129