[DPE-7316] Stereo mode - split charm#1677
Merged
Merged
Conversation
dragomirp
changed the title
dragomirp
commented
May 5, 2026
dragomirp
requested review from
carlcsaposs-canonical,
juju-charm-bot,
marceloneppel and
taurus-forever
and removed request for
a team
taurus-forever
previously approved these changes
May 6, 2026
Contributor
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
LGTM, some improvements for future to polish
marceloneppel
previously approved these changes
May 6, 2026
dragomirp
dismissed stale reviews from marceloneppel and taurus-forever
via
7bee41e
marceloneppel
previously approved these changes
May 7, 2026
taurus-forever
previously approved these changes
May 7, 2026
Contributor
taurus-forever
left a comment
taurus-forever
left a comment
There was a problem hiding this comment.
It pass all my PPA testing.. great progress!
dragomirp
dismissed stale reviews from taurus-forever and marceloneppel
via
394815a
taurus-forever
approved these changes
May 7, 2026
marceloneppel
approved these changes
May 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split of of #1664.
Postgresql side of the relation with the role config removed.