Skip to content

fix: make create-replication action fail cleanly without async-replication relation #1676

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SAY-5 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: make create-replication action fail cleanly without async-replication relation #1676

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6bb5d7a
fix: make create-replication action fail cleanly without async-replic…
May 5, 2026
dd6495a
fix(test): scope PropertyMock to prevent class-level leak
May 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions src/relations/async_replication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -567,6 +567,13 @@ def _on_create_replication(self, event: ActionEvent) -> None:
event.fail("There is already a replication set up.")
return

if self._relation is None:
event.fail(
"No async-replication relation has been established."
" Create the offer and relate the two clusters before running this action."
)
return

if self._relation.name == REPLICATION_CONSUMER_RELATION:
event.fail("This action must be run in the cluster where the offer was created.")
return
Expand Down
19 changes: 19 additions & 0 deletions tests/unit/test_async_replication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,6 +571,25 @@ def test_on_create_replication():

assert result is None

# 5. No async-replication relation established (regression for #1675).
mock_charm = MagicMock()
mock_event = MagicMock()

relation = PostgreSQLAsyncReplication(mock_charm)

relation._get_primary_cluster = MagicMock(return_value=None)

with patch.object(
PostgreSQLAsyncReplication, "_relation", new_callable=PropertyMock, return_value=None
):
result = relation._on_create_replication(mock_event)

assert result is None
mock_event.fail.assert_called_once_with(
"No async-replication relation has been established."
" Create the offer and relate the two clusters before running this action."
)


def test_promote_to_primary():
# 1.
Expand Down
Loading