[DPE-8932] Strict mode configuration #1389
Draft
+55
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dragomirp
force-pushed
the
dpe-8932-strict-mode
branch
from
e0f03fd to
315f821
Compare
github-actions
bot
added
the
Libraries: Out of sync
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 16/edge #1389 +/- ##
===========================================
+ Coverage 70.53% 70.64% +0.11%
===========================================
Files 16 16
Lines 4297 4293 -4
Branches 691 689 -2
===========================================
+ Hits 3031 3033 +2
+ Misses 1055 1050 -5
+ Partials 211 210 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dragomirp
force-pushed
the
dpe-8932-strict-mode
branch
3 times, most recently
from
0e04de2 to
d974297
Compare
dragomirp
commented
Jan 20, 2026
Comment on lines
-2393
to
-2406
| if value < 2: | ||
| from pydantic_core import InitErrorDetails | ||
|
|
||
| raise ValidationError.from_exception_data( | ||
| "ValidationError", | ||
| [ | ||
| InitErrorDetails( | ||
| type="greater_than_equal", | ||
| ctx={"ge": 2}, | ||
| input=value, | ||
| loc=("cpu_max_worker_processes",), | ||
| ) | ||
| ], | ||
| ) |
Contributor
Author
There was a problem hiding this comment.
Pydantic can validate this, there's no need to check separately.
dragomirp
commented
Jan 20, 2026
| # Update the configuration. | ||
| self._charm.set_unit_status(MaintenanceStatus("updating configuration"), refresh=refresh) | ||
| self._charm.update_config(refresh=refresh) | ||
| self._charm.updated_synchronous_node_count() |
Contributor
Author
There was a problem hiding this comment.
Should be called inside _charm.update_config().
dragomirp
changed the title
dragomirp
force-pushed
the
dpe-8932-strict-mode
branch
from
d974297 to
2b2e4a7
Compare
dragomirp
commented
Jan 23, 2026
|
|
||
| base_patch = {} | ||
| base_patch = { | ||
| **self._patroni.synchronous_configuration, |
Contributor
Author
There was a problem hiding this comment.
Update the sync node count and strict mode together with the other config params. To reduce the amount of PATCH calls.
dragomirp
commented
Jan 23, 2026
| base_patch = {} | ||
| base_patch = { | ||
| **self._patroni.synchronous_configuration, | ||
| "maximum_lag_on_failover": self.config.durability_maximum_lag_on_failover, |
Contributor
Author
There was a problem hiding this comment.
Patroni param, so should be part of the base patch.
2 tasks
dragomirp
force-pushed
the
dpe-8932-strict-mode
branch
from
d658b06 to
52cb476
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Solution
Checklist