Skip to content

Conversation

@taurus-forever
Copy link
Contributor

Backport #1375 to PG16.

Issue

At the moment charm action list-backups executes minutes on S3 buckets with hundreds backups,
while some common backups have thousand of backups causing action timeout.

The often config is hold backups for 30 days with nightly full backup and incremental backup each 15 minutes.

Solution

List S3 content recursively for archive part only. It will be enough to generate Timelines list.
This will skip the biggest neighbor folder backups, which used to eat most of the time in _list_timelines().

Checklist

  • I have added or updated any relevant documentation.
  • I have cleaned any remaining cloud resources from my accounts.

@taurus-forever taurus-forever added the bug Something isn't working as expected label Jan 14, 2026
@github-actions github-actions bot added the Libraries: Out of sync The charm libs used are out-of-sync label Jan 14, 2026
@codecov
Copy link

codecov bot commented Jan 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.53%. Comparing base (536bfa9) to head (caf6e46).

Additional details and impacted files
@@           Coverage Diff            @@
##           16/edge    #1376   +/-   ##
========================================
  Coverage    70.53%   70.53%           
========================================
  Files           16       16           
  Lines         4297     4297           
  Branches       691      691           
========================================
  Hits          3031     3031           
  Misses        1055     1055           
  Partials       211      211           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@taurus-forever taurus-forever force-pushed the alutay/speedup_list_backups_pg16 branch from 4f14a49 to caf6e46 Compare January 20, 2026 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working as expected Libraries: Out of sync The charm libs used are out-of-sync

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants