fix: GlobDistance handles / and * correctly#281
Open
letFunny wants to merge 1 commit intocanonical:mainfrom
Open
fix: GlobDistance handles / and * correctly#281letFunny wants to merge 1 commit intocanonical:mainfrom
letFunny wants to merge 1 commit intocanonical:mainfrom
Conversation
1 task
upils
approved these changes
Apr 10, 2026
| return Cost{SwapAB: Inhibit, DeleteA: Inhibit, InsertB: Inhibit} | ||
| } | ||
| if ar == '*' || br == '*' { | ||
| if ar == '*' && br == '/' { |
Collaborator
There was a problem hiding this comment.
This may be a matter of taste but we could get rid of a level of indentation with:
if ar == '*' && br == '/' {
return Cost{SwapAB: Inhibit, DeleteA: 0, InsertB: Inhibit}
}
if ar == '/' && br == '*' {
return Cost{SwapAB: Inhibit, DeleteA: Inhibit, InsertB: 0}
}
if ar == '*' || br == '*' {
return Cost{SwapAB: 0, DeleteA: 0, InsertB: 0}
}
| {f: strdist.GlobCost, r: 1, a: "a**f/hij", b: "abc/def/hik"}, | ||
| {f: strdist.GlobCost, r: 2, a: "a**fg", b: "abc/def/hik"}, | ||
| {f: strdist.GlobCost, r: 0, a: "a**f/hij/klm", b: "abc/d**m"}, | ||
| {f: strdist.GlobCost, r: 0, a: "/*foo/", b: "/foo/"}, |
Collaborator
There was a problem hiding this comment.
Out of consistency with other tests:
Suggested change
| {f: strdist.GlobCost, r: 0, a: "/*foo/", b: "/foo/"}, | |
| {f: strdist.GlobCost, r: 0, a: "/*a", b: "/a"}, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As in the other PR, I stumbled upon this bug while optimizing the algorithm. I need the fix to be in before continuing the work on performance.
Fixes the long-standing bug in #63.