fix: check payments.enabled in callback route middleware#616
Open
Anshumancanrock wants to merge 1 commit intocameri:mainfrom
Open
fix: check payments.enabled in callback route middleware#616Anshumancanrock wants to merge 1 commit intocameri:mainfrom
Anshumancanrock wants to merge 1 commit intocameri:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 5563256 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Collaborator
|
coverage: 65.086% (+0.1%) from 64.937% — Anshumancanrock:fix/callback-middleware-check-payments-enabled into cameri:main |
Anshumancanrock
force-pushed
the
fix/callback-middleware-check-payments-enabled
branch
from
a629acd to
7006b40
Compare
Anshumancanrock
force-pushed
the
fix/callback-middleware-check-payments-enabled
branch
from
7006b40 to
5563256
Compare
Merged
11 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
requireProcessormiddleware now also checkssettings.payments.enabledbefore allowing callback requests through. Previously it only verified the processor name matched, which meant a relay with payments disabled but a processor configured could still accept callbacks.Related Issue
Follow-up to #597
Motivation and Context
A relay operator might have
payments.enabled: falsewith a processor still configured (e.g. during setup or after disabling payments). Without this check, callback endpoints would still accept and process requests so the middleware should reject early in that case.How Has This Been Tested?
enabled: trueenabled: trueTypes of changes