[DRAFT] feat: standardize network/asset identifiers via CAIP-2 and CAIP-19#121
Open
MASDXI wants to merge 8 commits into
Open
[DRAFT] feat: standardize network/asset identifiers via CAIP-2 and CAIP-19#121MASDXI wants to merge 8 commits into
MASDXI wants to merge 8 commits into
Conversation
currency to CAIP-19 assets standard.currency to CAIP-19 assets standard.
currency to CAIP-19 assets standard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement/feature
What this PR does / why we need it:
What this PR does:
blockchainNetworkIdfrom a proprietary :<sub_id> format to the CAIP-2 standard. This allows for a more granular and extensible identification of namespaces (e.g.,eip155,cosmos,polkadot,avax).currencyproperty toassetsin bothBindBlockchainPublicAddressRequestandBlockchainPublicAddressResponseschemas.^[-a-z0-9]{3,8}:[-_a-zA-Z0-9]{1,32}\/[-a-z0-9]{3,8}:[-a-zA-Z0-9]{1,64}$).BLOCKCHAIN_PUBLIC_ADDRESS.INVALID_CURRENCYtoBLOCKCHAIN_PUBLIC_ADDRESS.INVALID_ASSETS(andASSETS_REQUIRED)..featuretests to align with the newassetsproperty and error codes.Why we need it:
evmosidentified as bothcosmos:evmos_9000-1andeip155:9000) to ensure compatibility across different wallet and provider ecosystems.currency(e.g., Fugible Token, Non-Fungible Tokens (NFTs), Soulbound Tokens (SBTs)) "asset" is the correct terminology. Pluralizing toassetsalso correctly matches thearraydata type.ETHorAVAX) is ambiguous in modern Web3 environments. For example,AVAXexists on three different native chains (X,P,C) with different address formats. Standardizing on CAIP-19 and SLIP-44 solves the routing problem and ensures API consumers can definitively identify the network and asset type.Which issue(s) this PR fixes:
issue: #72
Special notes for reviewers:
Warning
Breaking Change Alert for
vwipblockchainNetworkIdfrom a proprietary format to the CAIP-2 standard.currencykey in favor ofassets. Implementers currently using thevwip(Work In Progress) spec will need to update their request payloads and error handling logic to accommodateBLOCKCHAIN_PUBLIC_ADDRESS.INVALID_ASSETS.@bind_blockchain_public_address_400.06_invalid_assetsand@bind_blockchain_public_address_400.07_missing_assets) to ensure alignment with Telco Operator business rules.Changelog input
feat: migrate to CAIP-2/19 standards, renaming 'currency' to 'assets' and updating associated validation, error codes, and BDD suites.
Additional documentation