Skip to content

refactor: finish package split cleanup — remove ios renderer shims and deduplicate createVoltraComponent #156

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
V3RON merged 2 commits into from
May 25, 2026
Merged

refactor: finish package split cleanup — remove ios renderer shims and deduplicate createVoltraComponent #156

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42e7a22
refactor(ios): remove renderer shim files, import directly from core
burczu May 21, 2026
865b32b
refactor(ios,android): re-export createVoltraComponent from core
burczu May 21, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 6 additions & 36 deletions packages/android/src/jsx/createVoltraComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,6 @@
import type { ComponentType } from 'react'
import { createElement } from 'react'

export const VOLTRA_COMPONENT_TAG = Symbol.for('VOLTRA_COMPONENT_TAG')

export type VoltraComponent<TProps extends Record<string, unknown>> = ComponentType<TProps> & {
displayName: string
[VOLTRA_COMPONENT_TAG]: true
}

export type VoltraComponentOptions<TProps extends Record<string, unknown>> = {
toJSON?: (props: TProps) => Record<string, unknown>
}

export const createVoltraComponent = <TProps extends Record<string, unknown>>(
componentName: string,
options?: VoltraComponentOptions<TProps>
): VoltraComponent<TProps> => {
const Component = (props: TProps) => {
const toJSON = options?.toJSON ? options.toJSON : (value: TProps) => value
const normalizedProps = toJSON(props)

return createElement(componentName, normalizedProps)
}

Component[VOLTRA_COMPONENT_TAG] = true
Component.displayName = componentName

return Component as VoltraComponent<TProps>
}

export const isVoltraComponent = <TProps extends Record<string, unknown>>(
component: ComponentType<TProps>
): component is VoltraComponent<TProps> => {
return typeof component === 'function' && VOLTRA_COMPONENT_TAG in component
}
export {
createVoltraComponent,
isVoltraComponent,
VOLTRA_COMPONENT_TAG,
} from '@use-voltra/core'
export type { VoltraComponent, VoltraComponentOptions } from '@use-voltra/core'
42 changes: 6 additions & 36 deletions packages/ios/src/jsx/createVoltraComponent.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,36 +1,6 @@
import type { ComponentType } from 'react'
import { createElement } from 'react'

export const VOLTRA_COMPONENT_TAG = Symbol.for('VOLTRA_COMPONENT_TAG')

export type VoltraComponent<TProps extends Record<string, unknown>> = ComponentType<TProps> & {
displayName: string
[VOLTRA_COMPONENT_TAG]: true
}

export type VoltraComponentOptions<TProps extends Record<string, unknown>> = {
toJSON?: (props: TProps) => Record<string, unknown>
}

export const createVoltraComponent = <TProps extends Record<string, unknown>>(
componentName: string,
options?: VoltraComponentOptions<TProps>
): VoltraComponent<TProps> => {
const Component = (props: TProps) => {
const toJSON = options?.toJSON ? options.toJSON : (value: TProps) => value
const normalizedProps = toJSON(props)

return createElement(componentName, normalizedProps)
}

Component[VOLTRA_COMPONENT_TAG] = true
Component.displayName = componentName

return Component as VoltraComponent<TProps>
}

export const isVoltraComponent = <TProps extends Record<string, unknown>>(
component: ComponentType<TProps>
): component is VoltraComponent<TProps> => {
return typeof component === 'function' && VOLTRA_COMPONENT_TAG in component
}
export {
createVoltraComponent,
isVoltraComponent,
VOLTRA_COMPONENT_TAG,
} from '@use-voltra/core'
export type { VoltraComponent, VoltraComponentOptions } from '@use-voltra/core'
1 change: 0 additions & 1 deletion packages/ios/src/renderer/context-registry.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/dispatcher.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/element-registry.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/flatten-styles.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
export { flattenStyle } from './flatten-styles.js'
export {
type ComponentRegistry,
createVoltraRenderer,
Expand Down
1 change: 0 additions & 1 deletion packages/ios/src/renderer/render-cache.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/stylesheet-registry.ts
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion packages/ios/src/renderer/types.ts
View file
Open in desktop

This file was deleted.