Skip to content

fix: restore and polish various styling regression#124

Open
hristototov wants to merge 1 commit into
mainfrom
fix/styling-regressions
Open

fix: restore and polish various styling regression#124
hristototov wants to merge 1 commit into
mainfrom
fix/styling-regressions

Conversation

@hristototov
Copy link
Copy Markdown
Collaborator

Addressed the following styling issues:

  • for codeblocks, previously it was no border, but now it is has border - not sure if intentional
  • there is now a edit button in the sidebar which looks broken (2 icons, no spacing before marketing copy), there is also an edit button at the bottom so another one seems unexpected
  • the right border on active items in the sidebar is gone, not sure if it's intentional. also seems there is no spacing between sidebar items now
  • probably a bug in the theme itself, if i click the "Next page"/"Previous page" buttons at the bottom, it keeps its active styling even on the next page
  • the # link that you get before the heading when you hover it now has an underline when you hover the # - seems unintentional
  • the TOC on the right side don't have proper padding to show heading level like before
  • previously external links had this arrow after them, but now it's gone
  • the padding around the copy and wrap buttons on the codeblocks changed - previously they looked centered for single line codeblocks, but now they don't

Screenshots before and after the fixes

image image image
4-clear-active.state.mov
image image image image

@hristototov hristototov self-assigned this May 25, 2026
@github-actions github-actions Bot added the release: bug fix Bug Fix label May 25, 2026
@github-actions
Copy link
Copy Markdown

PR Preview Action v1.8.1

QR code for preview link

🚀 View preview at
https://callstack.github.io/rspress-theme/pr-preview/pr-124/

Built to branch gh-pages at 2026-05-25 10:46 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

@hristototov hristototov requested review from artus9033 and satya164 May 25, 2026 10:47
Copy link
Copy Markdown
Collaborator

@artus9033 artus9033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great job!

@satya164
Copy link
Copy Markdown
Member

satya164 commented May 25, 2026

This one looks wrong

13367

it should be like this (no gap between the 2 lines)

CleanShot 2026-05-25 at 13 31 27@2x

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants