-
Notifications
You must be signed in to change notification settings - Fork 3
chore: improve development workflow #103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey, thanks for the contribution 🎉
most changes look good, left few comments tho 👍
| "@changesets/cli": "^2.27.10", | ||
| "@commitlint/cli": "^20.3.1", | ||
| "@commitlint/config-conventional": "^20.3.1", | ||
| "husky": "^9.1.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
husky was added but I believe you forgot to create the actual hooks with it
package.json
Outdated
| "lint": "biome check --write", | ||
| "typecheck": "pnpm -r typecheck" | ||
| "typecheck": "pnpm -r typecheck", | ||
| "lint-staged": "lint-staged" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed, in husky you can just run pnpm lint-staged
| "lint-staged": "^16.2.7" | ||
| }, | ||
| "lint-staged": { | ||
| "*.{ts,tsx,js,jsx,json,md}": "biome format" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd rather go with lint which will run everything it can (lint,format,import organizer)
|
Hey @jbroma, thanks for the review! |
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems that there is still no setup for husky and running lint-staged (which was removed) - lets bring it back and setup husky, I believe it was pnpx husky init to create the precommit hook :)

Summary
This PR significantly improves the development workflow by implementing automated code quality and commit validation. It introduces:
1. Git Hooks (Husky)
2. Automated Code Formatting (Lint-Staged)
3. Commit Message Validation (Commitlint)
4. Enhanced npm Scripts
pnpm run build:all- Builds all packages in correct dependency orderpnpm run dev- Starts the tester dev serverpnpm run preview- Previews the production buildTest plan
Test pre-commit hook:
Test commit message validation:
Verify all scripts work: