-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add LLMS UI integration and custom LLMS controls in rspress theme #102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks good! can you update the UI slightly to look similar to the current website? less rounded corners, our button style? |
packages/theme/src/plugin/theme.ts
Outdated
| export { default as IconSmallMenu } from '../assets/small-menu.svg'; | ||
| export { default as IconSun } from '../assets/sun.svg'; | ||
| export { default as IconWarningBox } from '../assets/warning-box.svg'; | ||
| // export { default as IconCopy } from '../assets/copy.svg'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overriding those icons causes package/tester to crash with invalid svg error. I tried using other assets like "hero-bg-shape.svg" but it still crashes.
https://github.com/web-infra-dev/rspress/blob/main/packages/core/src/theme/icons.ts
Not sure what's causing this.
× caused by plugins in Compilation.hooks.processAssets
╰─▶ × Error: Invalid tag: data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjcxIiBoZWlnaHQ9IjI3MSIgdmlld0JveD0iMCAwIDI3MSAyNzEiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CjxwYXRoIGQ9Ik0xMTIuNjg3IDIwMy4yMjNIOTAuMTczOFYxODAuNzA5SDExMi42ODZWMTU4LjE5NUgxMzUuMTk4VjE4MC43MDlIMTEyLjY4N1YyMDMuMjIzWk05MC4xNzI5IDE4MC43MDlINjcuNjYwMlYxNTguMTk1SDkwLjE3MjlWMTgwLjcwOVpNNjcuNjU5MiAxNTguMTk1SDQ1LjE0NjVWMTM1LjY4M0g2Ny42NTkyVjE1OC4xOTVaTTE1Ny43MTMgMTU4LjE5NUgxMzUuMTk5VjEzNS42ODNIMTU3LjcxM1YxNTguMTk1Wk0xODAuMjI3IDEzNS42ODNIMTU3LjcxM1YxMTMuMTY5SDE4MC4yMjdWMTM1LjY4M1pNMjAyLjc0IDExMy4xNjlIMTgwLjIyN1Y5MC42NTUzSDIwMi43NFYxMTMuMTY5Wk0yMjUuMjU0IDkwLjY1NTNIMjAyLjc0VjY4LjE0MjZIMjI1LjI1NFY5MC42NTUzWiIgZmlsbD0iYmxhY2siLz4KPC9zdmc+Cg==
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
needs patching rspress here:
node_modules/.pnpm/@rspress+core@2.0.0-rc.6_@types+react@19.2.9/node_modules/@rspress/core/dist/theme/components/CodeButtonGroup/CopyCodeButton.js
kinda like this: web-infra-dev/rspress#2381
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be able to merge after this PR is merged and released.
web-infra-dev/rspress#3045
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Setup looks good, the error is an upstream issue in @rspress/core.
The buttons looks great, needs slight alignment style-wise to match the theme better, for example I don't think we need the onClick grey fill which is there currently. Would be lovely to consult this with our designers
05f6033 to
12a7aed
Compare
42f741a to
cb5a268
Compare
jbroma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fantastic job, thank you 🎉
Summary
Removed llms plugin as we can achieve it using SSG-MD and is recommended solution:
https://v2.rspress.rs/guide/basic/ssg-md
Used eject to export Lllms components from official Rspress implementation:
https://github.com/web-infra-dev/rspress/tree/main/packages/core/src/theme/components/Llms
Adjusted styles to match callstack theme.
Test plan
Screen.Recording.2026-01-21.at.19.48.44.mov