Skip to content

Conversation

@jaworek
Copy link
Collaborator

@jaworek jaworek commented Jan 21, 2026

Summary

Removed llms plugin as we can achieve it using SSG-MD and is recommended solution:
https://v2.rspress.rs/guide/basic/ssg-md

image

Used eject to export Lllms components from official Rspress implementation:
https://github.com/web-infra-dev/rspress/tree/main/packages/core/src/theme/components/Llms

Adjusted styles to match callstack theme.

Test plan

  1. Start dev and prod mode.
  2. Validate if "Copy Markdown" and dropdown with editor links is present
image
Screen.Recording.2026-01-21.at.19.48.44.mov

@jaworek jaworek changed the title feature: enable llms ui feat: enable llms ui Jan 21, 2026
@thymikee
Copy link
Member

Looks good! can you update the UI slightly to look similar to the current website? less rounded corners, our button style?

@jbroma jbroma added the release: feature New Feature label Jan 21, 2026
export { default as IconSmallMenu } from '../assets/small-menu.svg';
export { default as IconSun } from '../assets/sun.svg';
export { default as IconWarningBox } from '../assets/warning-box.svg';
// export { default as IconCopy } from '../assets/copy.svg';
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overriding those icons causes package/tester to crash with invalid svg error. I tried using other assets like "hero-bg-shape.svg" but it still crashes.

https://github.com/web-infra-dev/rspress/blob/main/packages/core/src/theme/icons.ts

https://github.com/web-infra-dev/rspress/blob/main/packages/core/src/theme/components/Llms/LlmsCopyButton.tsx

Not sure what's causing this.

× caused by plugins in Compilation.hooks.processAssets
  ╰─▶   × Error: Invalid tag: data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMjcxIiBoZWlnaHQ9IjI3MSIgdmlld0JveD0iMCAwIDI3MSAyNzEiIGZpbGw9Im5vbmUiIHhtbG5zPSJodHRwOi8vd3d3LnczLm9yZy8yMDAwL3N2ZyI+CjxwYXRoIGQ9Ik0xMTIuNjg3IDIwMy4yMjNIOTAuMTczOFYxODAuNzA5SDExMi42ODZWMTU4LjE5NUgxMzUuMTk4VjE4MC43MDlIMTEyLjY4N1YyMDMuMjIzWk05MC4xNzI5IDE4MC43MDlINjcuNjYwMlYxNTguMTk1SDkwLjE3MjlWMTgwLjcwOVpNNjcuNjU5MiAxNTguMTk1SDQ1LjE0NjVWMTM1LjY4M0g2Ny42NTkyVjE1OC4xOTVaTTE1Ny43MTMgMTU4LjE5NUgxMzUuMTk5VjEzNS42ODNIMTU3LjcxM1YxNTguMTk1Wk0xODAuMjI3IDEzNS42ODNIMTU3LjcxM1YxMTMuMTY5SDE4MC4yMjdWMTM1LjY4M1pNMjAyLjc0IDExMy4xNjlIMTgwLjIyN1Y5MC42NTUzSDIwMi43NFYxMTMuMTY5Wk0yMjUuMjU0IDkwLjY1NTNIMjAyLjc0VjY4LjE0MjZIMjI1LjI1NFY5MC42NTUzWiIgZmlsbD0iYmxhY2siLz4KPC9zdmc+Cg==
Image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs patching rspress here:
node_modules/.pnpm/@rspress+core@2.0.0-rc.6_@types+react@19.2.9/node_modules/@rspress/core/dist/theme/components/CodeButtonGroup/CopyCodeButton.js

kinda like this: web-infra-dev/rspress#2381

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will be able to merge after this PR is merged and released.
web-infra-dev/rspress#3045

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup looks good, the error is an upstream issue in @rspress/core.

The buttons looks great, needs slight alignment style-wise to match the theme better, for example I don't think we need the onClick grey fill which is there currently. Would be lovely to consult this with our designers

Copy link
Member

@jbroma jbroma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fantastic job, thank you 🎉

@jaworek jaworek changed the title feat: enable llms ui feat: add LLMS UI integration and custom LLMS controls in rspress theme Jan 23, 2026
@jbroma jbroma merged commit befc669 into callstack:main Jan 23, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release: feature New Feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants