fix(android): stop leaking executor thread in getBitmapDrawable#805
Open
pataar wants to merge 1 commit intocallstack:mainfrom
Open
fix(android): stop leaking executor thread in getBitmapDrawable#805pataar wants to merge 1 commit intocallstack:mainfrom
pataar wants to merge 1 commit intocallstack:mainfrom
Conversation
ReactSlider.getBitmapDrawable creates a single-thread ExecutorService per call and never shuts it down, so every setThumbImage call leaks the worker thread for the lifetime of the process. Wrap the submit/get in a try/finally and shut down the executor once the bitmap decode is complete. Behaviour is unchanged; only the now-idle worker thread is reclaimed.
pataar
force-pushed
the
perf/slider-native-marginal-fixes
branch
2 times, most recently
from
f5fa3a5 to
2696bb8
Compare
pataar
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
ReactSlider.getBitmapDrawablecreatesExecutors.newSingleThreadExecutor()per call and never shuts it down, so everysetThumbImagecall leaks the worker thread for the lifetime of the process. Wrapped the submit/get in a try/finally and shut down the executor once the bitmap decode is complete.The submit-then-immediately-
get()pattern itself is preserved — the off-thread decode is presumably there to keepBitmapFactory.decodeStream(new URL(uri).openStream())off the main thread for StrictMode. Behaviour is unchanged; only the now-idle worker thread is reclaimed.Test Plan:
The Android slider has no JVM unit tests in this repo, so verification is by inspection.
Recommended manual check: mount/unmount a slider with a
thumbImagerepeatedly and confirm the live thread count does not grow indefinitely (e.g. via Android Studio's Profiler).