perf: memoize options/thumbImage and stop mutating on inverted#804
Open
pataar wants to merge 1 commit intocallstack:mainfrom
Open
perf: memoize options/thumbImage and stop mutating on inverted#804pataar wants to merge 1 commit intocallstack:mainfrom
pataar wants to merge 1 commit intocallstack:mainfrom
Conversation
- Slider: memoize the `options` array and the resolved `thumbImage` so they're stable across renders, which keeps StepsIndicator's existing `useCallback` memos effective. - StepsIndicator: use `options.slice().reverse()` instead of `options.reverse()` to avoid mutating the parent's array in place.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Three marginal-but-easy perf/correctness fixes in the JS layer. No public API changes, no behaviour changes for end users.
optionsinSlider.tsx— theArray.from(...)call rebuilt the array on every render. Wrapping it inuseMemoalso restores the effectiveness ofStepsIndicator's existinguseCallback/useMemo, which currently bust every render because the parent hands them a freshly allocated array.thumbImageinSlider.tsx—Image.resolveAssetSource(...)ran on every render. Memoized onprops.thumbImage/props.StepMarker.optionsinStepsIndicator.tsx—options.reverse()mutates the array passed in from the parent in place. Switched tooptions.slice().reverse(). Mostly a correctness fix; with the parent now memoizing the array, the in-place reverse would also have re-reversed the same array each render.Test Plan:
npm testfrompackage/→ 4 suites, 16 tests passing.npm run lintfrompackage/→ no new warnings introduced.inverted, with non-zerostep, and withthumbImageset, to confirm no visual regression.