chore: Converted CircleCi to Github workflows#4884
Conversation
|
Hey @ruben-rebelo, thank you for your pull request 🤗. The documentation from this branch can be viewed here. |
|
The mobile version of example app from this branch is ready! You can see it here. |
BogiKay
left a comment
BogiKay
left a comment
There was a problem hiding this comment.
great work 🔥 Left a few comments with ideas for potential improvements
| - uses: actions/checkout@v4 | ||
| - uses: actions/setup-node@v4 | ||
| with: | ||
| node-version: '20.19.0' |
There was a problem hiding this comment.
can we extract node version to env var? or use version from .nvmrc (setup-node action has an option node-version-file)
| } | ||
|
|
||
| deploy-docs: | ||
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' |
There was a problem hiding this comment.
deploy-docs runs even if checks fail. I'd run it when all steps pass
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | |
| if: github.event_name == 'push' && github.ref == 'refs/heads/main' | |
| needs: [lint, typescript, unit-tests, build-package] |
| branches: | ||
| - main | ||
| pull_request: | ||
|
|
There was a problem hiding this comment.
What do you think about defining concurrency rules to limit runs on frequent pushes?
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.event.pull_request.number || github.sha }} | |
| cancel-in-progress: ${{ github.event_name == 'pull_request' }} |
| unit-tests: | ||
| runs-on: ubuntu-latest | ||
| steps: | ||
| - uses: actions/checkout@v4 |
There was a problem hiding this comment.
I didn't count, but looks like all jobs use the same steps (checkout, setup node, install deps...). Let's create a composite action with steps that we need to setup everything before we run a job.
2 participants
This is a Simple PR to convert all the jobs from CircleCi to GitHub Actions to improve the maintenance.
Motivation
The main motivation here is maintainability, GitHub actions is much more stable than CircleCi and easier to maintain.
Related issue
N/a
Test plan
N/a