Skip to content

Fix MQTT connection loss and display freeze after extended uptime #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Copilot wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix MQTT connection loss and display freeze after extended uptime #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
66658d6
Fix MQTT reconnect double-connect, blocking delays, connection timeou…
Copilot Apr 18, 2026
df1f992
Clarify setTimeout unit in comment
Copilot Apr 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/display_handler.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -193,7 +193,7 @@ void DisplayHandler::loop() {

// Global Vars
char message[LCD_COLS]{' '};
uint16_t i = writeIndex - scrollPosition;
uint16_t i = (writeIndex - scrollPosition + MAX_ALARMS) % MAX_ALARMS;

// First line: Always show current frequency
if (hasAnalysis && currentAnalysis.isValidSignal) {
Expand Down
7 changes: 3 additions & 4 deletions src/networking.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#include "networking.h"

Networking::Networking() : mqttClient(espClient){}
Networking::Networking() : mqttClient(espClient), lastReconnectTry(0) {}

void Networking::begin() {
if (WIFI_CONFIGURED) {
Expand All @@ -27,22 +27,21 @@ void Networking::setupWiFi() {
void Networking::setupMqtt() {
Serial.println("Setting up MQTT...");
mqttClient.setServer(MQTT_SERVER, MQTT_PORT);
espClient.setInsecure();
espClient.setInsecure();
espClient.setTimeout(5); // 5 seconds connection timeout
}

void Networking::reconnectWiFi() {
Serial.println("WiFi lost connection. Reconnecting...");
WiFi.disconnect();
WiFi.reconnect();
delay(1000);
}

void Networking::reconnectMQTT() {
Serial.println("Attempting MQTT connection...");
String clientId = "FreqSensor-";
clientId += String(random(0xffff), HEX);
mqttClient.disconnect();
mqttClient.connect(clientId.c_str(), MQTT_USERNAME, MQTT_PASSWORD);
bool connected = mqttClient.connect(clientId.c_str(), MQTT_USERNAME, MQTT_PASSWORD);
if (connected) {
Serial.println("MQTT connected!");
Expand Down