Update for vite compatibility #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We switched from vue-cli-service and node 16 to electron-vite and node 18. This causes an issue with modules not being able to use their inherited constructors. Example: when calling new GML2(), we would get an error claiming that call is "not a constructor", even though it seemed to find format/GML2.js just fine. Our solution is to explicitly export the components that we need via index.js files, which results in usable inheritance and no run time errors. Perhaps a switch to ESM would solve this in the future? We searched for any vite config that may solve the issue instead, but had no luck.
The webpack config file update was necessary to get through some bufferutil errors during the build