fix(caldav): allow same base URL with different credentials and dedupe by full identity#28725
Open
AJ0070 wants to merge 2 commits intocalcom:mainfrom
Open
fix(caldav): allow same base URL with different credentials and dedupe by full identity#28725AJ0070 wants to merge 2 commits intocalcom:mainfrom
AJ0070 wants to merge 2 commits intocalcom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR fixes CalDAV account installation so multiple accounts can be added when they share the same base CalDAV URL but use different credentials.
Changes included
Mandatory Tasks (DO NOT REMOVE)
N/A (no docs change needed; behavior bugfix only).
How should this be tested?
Are there environment variables that should be set?
CALENDSO_ENCRYPTION_KEYmust be set (test uses a stubbed value).What are the minimal test data to have?
What is expected (happy path) to have (input and output)?
Any other important info that could help to test that PR
corepack yarn vitest run add.test.tscorepack yarn biome check add.ts add.test.tsChecklist