refactor(bookings): add round-robin host effective-limits foundation and flow wiring#28715
Open
manurana26770 wants to merge 4 commits intocalcom:mainfrom
Open
refactor(bookings): add round-robin host effective-limits foundation and flow wiring#28715manurana26770 wants to merge 4 commits intocalcom:mainfrom
manurana26770 wants to merge 4 commits intocalcom:mainfrom
Conversation
…dividual-member-limits
|
|
Contributor
There was a problem hiding this comment.
1 issue found across 6 files (changes from recent commits).
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="packages/features/users/lib/getRoutedUsers.ts">
<violation number="1" location="packages/features/users/lib/getRoutedUsers.ts:127">
P2: Large duplicated host-projection logic across booking paths increases drift risk for override/effective-limit fields.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Contributor
Author
|
@CarinaWolli could you plz review or tell anybody to review this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR introduces the first foundation slice for per-member round-robin limit settings without changing current booking behavior.
What changes
Visual Demo (For contributors especially)
N/A for this foundation PR. The change is internal plumbing and does not introduce a user-facing UI change yet.
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
This PR is a foundation slice, so testing focuses on behavior preservation and contract validation.
yarn vitest run packages/features/bookings/lib/handleNewBooking/test/resolveRoundRobinHostEffectiveLimits.test.tsyarn vitest run packages/features/bookings/lib/handleNewBooking/test/computeTeamData.test.tsyarn vitest run packages/features/bookings/lib/handleNewBooking/test/round-robin-no-hosts.test.tsyarn vitest run packages/features/users/lib/getRoutedUsers.test.tsChecklist