fix: Cal Video fails to load in Firefox with Enhanced Tracking Protection#28714
Open
sudoKrishna wants to merge 7 commits intocalcom:mainfrom
Open
fix: Cal Video fails to load in Firefox with Enhanced Tracking Protection#28714sudoKrishna wants to merge 7 commits intocalcom:mainfrom
sudoKrishna wants to merge 7 commits intocalcom:mainfrom
Conversation
Contributor
|
Hey there and thank you for opening this pull request! 👋🏼 We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted. Details: |
Contributor
There was a problem hiding this comment.
3 issues found across 4 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name=".env.example">
<violation number="1" location=".env.example:74">
P1: Hardcoded default secrets in .env.example create shared credentials for deployments that copy the defaults, undermining auth/session signing and encryption.</violation>
</file>
<file name="apps/web/modules/videos/views/videos-single-view.tsx">
<violation number="1" location="apps/web/modules/videos/views/videos-single-view.tsx:156">
P1: Failure timeout is unconditional and not cancelled on successful call join, so it can incorrectly switch UI to `videoFailed` after 8s.</violation>
<violation number="2" location="apps/web/modules/videos/views/videos-single-view.tsx:189">
P2: Failure fallback UI can render without destroying the active Daily call, potentially leaking background media/session resources.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review, or fix all with cubic.
Author
|
Hi @calcom/foundation Could a maintainer please approve the workflows to run? This PR fixes #28473 where Firefox users with Enhanced Tracking Protection see an infinite loading screen instead of joining the video call. All review issues |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #28473
Issue
Cal Video fails to load in Firefox when Enhanced Tracking Protection is enabled.
Users see an infinite loading screen.
Fix
Testing