fix: preserve array query parameters during dynamic group redirect#28698
Closed
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Closed
fix: preserve array query parameters during dynamic group redirect#28698jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
jaydeep-pipaliya wants to merge 1 commit intocalcom:mainfrom
Conversation
Next.js context.query values can be string | string[], but the redirect logic cast them to Record<string, string> before passing to URLSearchParams. This caused array params like ?user=john&user=doe to be serialized as user=john,doe instead of preserving each value. Iterate over query entries and use searchParams.append() to correctly handle both single and array values. Fixes calcom#28687
|
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Member
sahitya-chandra
left a comment
sahitya-chandra
left a comment
There was a problem hiding this comment.
closing in favor of #28688
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes incorrect serialization of array query parameters in the dynamic group redirect logic.
Root cause: In
getServerSideProps,context.queryis cast toRecord<string, string>and passed tonew URLSearchParams(). However, Next.js query params can bestring | string[]— when a key appears multiple times (e.g.?user=john&user=doe), the value is an array. The cast loses this structure, producinguser=john,doeinstead ofuser=john&user=doe.Fix: Iterate over
context.queryentries and usesearchParams.append()for each value, correctly handling both single strings and arrays.Fixes #28687
Test plan
/john+doe?user=john&user=doe?user=john&user=doe?redirect=false