Skip to content

fix: Restore Google Meet videoCallUrl in metadata#28689

Draft
Sumanthvu wants to merge 4 commits intocalcom:mainfrom
Sumanthvu:fix-google-meet-metadata
Draft

fix: Restore Google Meet videoCallUrl in metadata#28689
Sumanthvu wants to merge 4 commits intocalcom:mainfrom
Sumanthvu:fix-google-meet-metadata

Conversation

@Sumanthvu
Copy link
Copy Markdown

@Sumanthvu Sumanthvu commented Mar 31, 2026

What does this PR do?

This PR resolves the regression where the Google Meet videoCallUrl was missing from the booking metadata.

Following the Calendar Sync refactor, the code was incorrectly assuming the calendar integration payload would always be located at results[0]. This PR updates RegularBookingService.ts to dynamically extract the hangoutLink from the actual calendar result rather than relying on a hardcoded array index. It also adds regression tests to fresh-booking.test.ts to ensure the URL is properly persisted.

@Sumanthvu Sumanthvu requested a review from a team as a code owner March 31, 2026 21:50
@github-actions github-actions bot added the 🐛 bug Something isn't working label Mar 31, 2026
Copy link
Copy Markdown
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 14 files

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 31, 2026

CLA assistant check
All committers have signed the CLA.

@francescogatto
Copy link
Copy Markdown

It looks like this PR includes formatting changes that are not aligned with the repository configuration.

The project uses Biome (see biome.json), which explicitly enforces:

  • semicolons: "always"

However, several changes in this PR remove semicolons and adjust formatting inconsistently with Biome rules.

This suggests the code may have been formatted with a different tool (e.g. Prettier with semi: false) or without running the project's formatter.

To keep the codebase consistent and avoid unnecessary diff noise, it would be better to:

  • revert unrelated formatting changes
  • run Biome formatter before committing

This PR should ideally contain only the functional fix.

Copy link
Copy Markdown

@francescogatto francescogatto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Too much noise, please commit only relevant fix without any change to other changes to other files

Copy link
Copy Markdown
Contributor

@Ryukemeister Ryukemeister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi there, thank you for your contribution. @francescogatto is right here, this is too much noise. can you also commit the relevant files and revert the other please. can you also attach a visual demo of the fix before/after, thank you!

@Ryukemeister Ryukemeister marked this pull request as draft April 1, 2026 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🐛 bug Something isn't working size/XXL

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Regression in v6.2 (self hosted): Google Meet videoCallUrl missing from metadata when using Google Calendar integration

4 participants