fix: intersect guest availability during rescheduling flow #16378#28663
Draft
nyazsrhana-arch wants to merge 2 commits intocalcom:mainfrom
Draft
fix: intersect guest availability during rescheduling flow #16378#28663nyazsrhana-arch wants to merge 2 commits intocalcom:mainfrom
nyazsrhana-arch wants to merge 2 commits intocalcom:mainfrom
Conversation
Implement function to filter host availability based on guest slots.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Ryukemeister
requested changes
Apr 1, 2026
Contributor
Ryukemeister
left a comment
Ryukemeister
left a comment
There was a problem hiding this comment.
hey there, thank you for your contribution. I think this PR is still not complete, because even if the function getSharedAvailabilitySlots worked perfectly, there's no code connecting it to the booker or rescheduling UI. there are also no test cases present, hence i'll shift this into draft. please ping me when this is complete.
| @@ -0,0 +1,17 @@ | |||
| export function getSharedAvailabilitySlots(hostSlots: any[], guestSlots: any[]) { | |||
Contributor
There was a problem hiding this comment.
I don't see this being used anywhere, seems to be dead code. @nyazsrhana-arch can you confirm this?
|
|
||
| type BookingInput = { | ||
| attendees?: { email: string; name: string }[] | null; | ||
| attendees: { id?: number; email: string; name: string }[] | null; |
Contributor
There was a problem hiding this comment.
this can be a breaking change, what was the reason behind making attendees not optional?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #16378 by ensuring that only overlapping time slots between the host and the guest are displayed during the rescheduling process.
Changes Made
getHostsAndGuests.tsto includeidfor guests.getSharedAvailability.tsto handle the intersection logic between host and guest slots.Verification
/claim #16378