fix: destructure formState properties to enable proper Proxy subscription#28661
Open
Umesh-Tiruvalluru wants to merge 1 commit intocalcom:mainfrom
Open
fix: destructure formState properties to enable proper Proxy subscription#28661Umesh-Tiruvalluru wants to merge 1 commit intocalcom:mainfrom
Umesh-Tiruvalluru wants to merge 1 commit intocalcom:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes #25208
Destructures
formStateproperties (isDirty,isSubmitting,isValid,errors) at the component level instead of accessing them directly through the form object.Per react-hook-form's documentation,
formStateis wrapped with a Proxy and properties must be destructured to enable proper subscription and re-renders. The same fix was already applied in #25197 for routing forms — this PR extends it to all remaining instances.Affected files:
AgentConfigurationSheet.tsx—isDirty(two forms)WorkflowPage.tsx—isDirtyEventTypeLayout.tsx—isDirtyIntegrationAttributeSyncCard.tsx—isDirtyWebhookForm.tsx—isDirtyAvailabilitySettings.tsx—isDirtyPasswordView.tsx—isDirty,isSubmittingAdminUser.tsx—isValid,isSubmittingLicenseSelection.tsx—isValidEditLocationDialog.tsx—errorsMandatory Tasks (DO NOT REMOVE)
How should this be tested?