fix(auth): persist user locale on signup and oauth login#27966
Open
AritraDey-Dev wants to merge 4 commits intocalcom:mainfrom
Open
fix(auth): persist user locale on signup and oauth login#27966AritraDey-Dev wants to merge 4 commits intocalcom:mainfrom
locale on signup and oauth login#27966AritraDey-Dev wants to merge 4 commits intocalcom:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
2 issues found across 3 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/app/api/auth/signup/handlers/calcomSignupHandler.ts">
<violation number="1" location="apps/web/app/api/auth/signup/handlers/calcomSignupHandler.ts:231">
P2: Existing invited users updated through the upsert path never get the new locale persisted; locale is only set in `create`. Add `locale: userLanguage` to the `update` clause so completing signup updates locale for existing users.</violation>
</file>
<file name="apps/web/app/api/auth/signup/handlers/selfHostedHandler.ts">
<violation number="1" location="apps/web/app/api/auth/signup/handlers/selfHostedHandler.ts:140">
P2: Locale is only set in the upsert create branch; existing users updated via invite flow never get their locale persisted. Add locale to the upsert update payload to save language for pre-created/invited users.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
Fixes calcom#19646 Signed-off-by: Aritra Dey <adey01027@gmail.com>
2bcfefb to
1d4fab8
Compare
Signed-off-by: Aritra Dey <adey01027@gmail.com>
Member
|
@AritraDey-Dev can you please check cubic comments |
Contributor
Author
|
@romitg2 i think i’ve already resolved them in the next commit. am I missing anything? |
Member
oh sorry, then it's fine. could you add before video, just to be sure that issue is still reproducible. |
Contributor
Author
sure! added in the PR description.thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Visual Demo (For contributors especially)
Before:
Screencast.from.2026-02-15.21-11-22.webm
After the fix:
Screencast.from.2026-02-15.20-20-15.webm
This PR ensures the website always stays in your preferred language by saving your language choice to the database when you sign up or log in.
A visual demonstration is strongly recommended, for both the original and new change (video / image - any one).
Video Demo (if applicable):
Image Demo (if applicable):
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
Sign up or log in via OAuth with a specific browser language and verify that the UI language persists even after subsequently changing your browser's language settings.