fix: internationalize PayPal Setup component#27949
fix: internationalize PayPal Setup component#27949veeceey wants to merge 3 commits intocalcom:mainfrom
Conversation
Replace all hardcoded strings in the PayPal Setup component with t() locale function calls. This includes form labels, headings, setup instructions, requirement lists, and the reminder paragraph. Added corresponding translation keys to en/common.json. Also removes the @todo: translate comment since the work is now done. Fixes calcom#27907
There was a problem hiding this comment.
1 issue found across 2 files
Prompt for AI agents (all issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/web/public/static/locales/en/common.json">
<violation number="1" location="apps/web/public/static/locales/en/common.json:4641">
P3: Duplicate "resources" key added; common.json already defines "resources" earlier in the file. Duplicate JSON keys are invalid and the later value overwrites the earlier entry.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
|
Hey @veeceey, I noticed the bot flagged a duplicate resources key in common.json. Since this PR is still a draft and has failing checks, would u like me to help fix this or look for other untranslated strings in the component that might have been missed? |
|
Hey @vetrivelanarsu, thanks for the heads up! I already fixed the duplicate |
Noticed the PayPal Setup component had a bunch of hardcoded English strings with a
@TODO: translatecomment sitting there. Went through and replaced all of them witht()calls.What changed:
client_id,secret_key)t()en/common.jsonfor the PayPal-specific strings@TODO: translatecomment since it's done nowsave,here,keys_have_been_saved,client_id,reminder)Testing:
Fixes #27907