Fix various issues for 5.x release #998

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

markstory merged 1 commit into 5.x from fix/5x-release-issues

Jan 13, 2026

+88 −26

Member

dereuromark commented Jan 13, 2026

Summary

Fixes various issues identified during the 5.x release preparation:

Fix README.md coverage badge pointing to 3.x branch instead of 5.x
Update MigrationHelper comments to remove outdated phinx-related TODOs (phinx was removed in 5.x)
Add comprehensive database-specific limitations documentation covering SQL Server, SQLite, PostgreSQL, and MySQL/MariaDB
Fix PHPStan issues by adding proper @var type hints for Bake event subjects
Update PHPStan baseline to remove the 3 now-fixed loadHelper() errors

Changes

Documentation

writing-migrations.rst: Added new "Database-Specific Limitations" section documenting:
- SQL Server: check constraints, table comments, INSERT IGNORE not supported
- SQLite: foreign key names, table comments, check constraint modifications, partitioning not supported
- PostgreSQL: KEY partitioning not supported
- MySQL/MariaDB: insertOrUpdate conflict columns behavior, MariaDB GIS issues

Code Quality

BakeMigrationCommand.php, BakeMigrationDiffCommand.php, BakeMigrationSnapshotCommand.php: Added proper @var \Bake\View\BakeView annotations to fix PHPStan errors about undefined loadHelper() method
MigrationHelper.php: Replaced outdated phinx TODOs with accurate comments explaining precision/scale conversion between CakePHP TableSchema and SQL standard formats
phpstan-baseline.neon: Removed 3 fixed errors from baseline

Related

Part of the preparation for 5.x major release (#995)


          Fix various issues for 5.x release

32cd757

- Fix README coverage badge pointing to 3.x instead of 5.x
- Update MigrationHelper comments (remove outdated phinx TODOs)
- Add database-specific limitations documentation
- Fix PHPStan issues by adding proper type hints for Bake event subjects
- Update PHPStan baseline to remove fixed errors

markstory added this to the 5.x (CakePHP 5.x, builtin-backend) milestone

markstory merged commit 886c68d into 5.x

14 checks passed

markstory deleted the fix/5x-release-issues branch

January 13, 2026 04:40

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet