Improve type safety in nullable detection and comparisons #1004
+7
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix strpos() casting bug in ColumnParser - (bool)strpos() returns false when needle is at position 0, use str_contains() instead - Replace loose comparisons (== !=) with strict comparisons (=== !==) in Manager.php for version and breakpoint checks
PostgreSQL and SQL Server return boolean columns as strings or actual booleans instead of integers, causing strict equality checks to fail.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
strpos()casting bug inColumnParser.php:77-(bool)strpos($type, '?')incorrectly returnsfalsewhen?is found at position 0 becausestrpos()returns0(falsy). Changed tostr_contains()which returns a boolean.==/!=) with strict comparisons (===/!==) inManager.phpfor version and breakpoint checks to prevent type coercion issues.