Add nextOccurrenceOf() and previousOccurrenceOf() methods#496
Open
dereuromark wants to merge 1 commit into3.nextfrom
Open
Add nextOccurrenceOf() and previousOccurrenceOf() methods#496dereuromark wants to merge 1 commit into3.nextfrom
dereuromark wants to merge 1 commit into3.nextfrom
Conversation
These methods solve the problem of constructing a relative date that always points to the next (or previous) future occurrence of a specific day and time. Unlike next()/previous(), these methods consider BOTH the day AND the time. If today is the target day: - nextOccurrenceOf: returns today if time hasn't passed, else next week - previousOccurrenceOf: returns today if time has passed, else last week Example: // If it's Tuesday 9am, get Tuesday 12pm (today) // If it's Tuesday 4pm, get Tuesday 12pm (next week) $date = Chronos::now()->nextOccurrenceOf(Chronos::TUESDAY, 12, 0); Related to #406
Contributor
|
Seems OK to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new methods to
Chronosthat solve the problem of constructing a relative date that always points to the next (or previous) future occurrence of a specific day and time.Problem
As described in #406, PHP's relative date parsing with
nextonly considers the date, not the time:There's no way to get "the next future occurrence of Tuesday 12pm" that returns today if it's before noon, or next week if it's after noon.
Solution
Two new methods:
nextOccurrenceOf(int $dayOfWeek, int $hour, int $minute, int $second)- Returns the next future occurrence, considering both day and timepreviousOccurrenceOf(int $dayOfWeek, int $hour, int $minute, int $second)- Returns the most recent past occurrenceBehavior at exact time
When the current time matches exactly,
nextOccurrenceOfreturns next week andpreviousOccurrenceOfreturns last week (strict comparison, not inclusive).Discussion Points
nextOccurrenceOfvsnextOrSameor something shorter?greaterThanOrEquals?Related to #406
Test plan